Redo adapter inheritance #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
blag
force-pushed
the
redo-adapter-inheritance
branch
from
6dd538e to
3a14cdd
Compare
|
I fixed a few things in the changelog, and added PR references to the most recent changes, including #190. |
arm4b
reviewed
Aug 5, 2019
arm4b
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of #190.
This PR slightly refactors the adapter inheritance for Slack-like adapters.
It adds in an intermediary
SlackLikeAdapterfor the Slack-like providers. This should make it easier to useDefaultAdaptermethods in subclasses, like with what is done inSparkAdapter.formatDataandSlackLikeAdapter.normalizeCommand.This makes things a bit easier:
I also removed the
normalizeAddresseefrom the MS Teams adapter, since it was an override of the same function fromDefaultAdapter(and the MS Teams adapter inherits fromDefaultAdapter). The two functions were identical, however, so it makes no sense to override that function. And since the two functions were identical, I didn't need to change the tests at all for this fix.Once #190 is merged, I will either rebase and merge this with GitHub, or I will manually rebase this branch on that one, force push, and merge it.Done.