-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mattermost adapter #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a Changelog for this PR.
Based on #193 release, Changelog sync-up in master
should eventually happen.
23b6b21
to
44ca041
Compare
As mentioned in #193, So let's please mention in Changelog a few notes about 0.9.7 for our users to have this information visible in history. This is not any worse then split-brain with patch and I hope its first and last time we're doing this. Additionally, are you going to release |
I closed #193. We won't do a split brain release. I have a version bump local branch ready to go, but I'd like to merge this and then rebase that branch on top of |
Sure, works for me. |
This is the fix for the Mattermost adapter from this forum post.
I have tested this manually with a minimal Mattermost server in a VM.
The
slack-attachment
event was removed from the hubot-matteruser dependency in PR 71, but our Mattermost adapter did not get updated to avoid using that.I switched over to using the
send
method from hubot-matteruser.Note: That methods accepts two parameters:
envelope
and a variadic parameterstrings
, but contrary to the name, thestrings
parameter also works just fine if each "string" is a message-like object, because it callspostMessage
from mattermost-client, and that handles objects:(reformatted that code slightly to improve readability)
Once #190 and #191 are merged, I will either rebase and merge this with GitHub, or I will manually rebase this branch on #191, force push, and merge it.