-
Notifications
You must be signed in to change notification settings - Fork 327
Sn ap2024 instanescan 02 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
bird-03
wants to merge
3
commits into
ServiceNowDevProgram:master
from
bird-03:sn_ap2024_instanescan_02
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
CuNEYHj5RbBsjVJxohTMD1xntLLtuzW06YrIQxv_dnuv66Z-CP9Yyz94aT1y6VMee62ueoZ-zoVm79qzmSN0EDnNTIajGUE-L9E8z-wSmPjpDRK6unp5pT-WyQru961HXU1NDT6tYoVYpmHPnC1pxK1hGqlJ5xCFlFjoYHaWTOMQ-jgr2lppwmOLGMGR7znGbC3ffVubbJzVWxZF2A54U5qoSwKmMb-Sl6nBVJvbZz8finGJvOBn8WzxH6DP_rUNqXJ4ZflVbC2EWzi2mlf_jhEvu35jXElgy6I7myTSoOJvWiK8J6arVkKEt1MNTtewGnDrFnAbFFZ53T08x7UafmirFgZuS4MbzwCYGQ_dX9IlcB-5OLXuB1JYApTLKEJnT364IFKOpAgwzZm5F9dhRAYQG6qVRonDCHrXl1ZJ1WFEMgDCksXtQpTcc53Fe-cH348-sbttOrFExqMtN8HmrJxdjJWFQB0WIPnb7BLMIc6qvc0QIfku9KZpHSlse1cttB-pn_l5UM07YLgjoWCB2wvGaLkZdjDOT0MZizytu7SaAs0SFgm4Q2g4p3xTJ9C78cM24TaT0oQ_gIehRDaf-ETeb4XCdMj1hpaRB4PR2JquoRXJvkfZ7bB6l0ahyfDeQvKqk2cmDf0Mt2CKXeALoAOwe3vhtLMTXKOL1NBAjm4 | ||
ocgk30OZCgJiO0J_9mbH0UAMvW8OyUPilbYIaM5smjvny01iks-MTTaCCpQ81BtPUZhdkceTlwBLF2OvnpXLSz4iaDnIwRNtx2sny25-eeMsU9V1NkqtrANn3WoZKeS44ixvbN03bEWrxXfaW9-L4SL_P_Y8-hGbwqjST2ZNcSOgtvhRQAn1djeY3Fz0AQC4IwBFjbKfqW2SYnHl0FVjwQc67CGbjC3Qa6iD9igvlZCHnUBTTdNAOObzFkX-y-1PBWL0A2v3FHBrv6hXtLf5ShkFoH__0tnctuysBHEvYjOkY59m4-73D76TcfUkHnP93hoMh2LoM4JED0AATNYcTXlmKVSnkNOeyGHNZ2bAotMlWnwBlvv-3ru6xzFhAM4BYniFJsdavRuOF1J-IkIEMFYVCK7A3X2m4Zf0bEPrNO6dX-5qeOL0l_720h6DrECrJlaOa2ZIWHgZUkGVZl8zC8XEPeENNZ5iC660wdTlR6LAWYBYP25o2yGRsgQO8_jY4O0kFTt32WF5kfQAyATANT3Wv8poZavzmCHq5jNy2XEhJ3q8foHo3USLJZujr6WOF0fjRz5TCiQxtS_40LcwS2ulTiJQJOABVZeXkJgShaEXY9LLbdTyDtivNMyoovjuIRxsKNEFC8A67Is3vXCDys6aw9TmxCqN7QZ90SsewyQ |
49 changes: 49 additions & 0 deletions
49
...67c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_cfe622458301d2100283b955eeaad366.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check"> | ||
<scan_table_check action="INSERT_OR_UPDATE"> | ||
<active>true</active> | ||
<advanced>false</advanced> | ||
<category>performance</category> | ||
<conditions table="sys_properties">ignore_cache=true^EQ<item endquery="false" field="ignore_cache" goto="false" newquery="false" operator="=" or="false" value="true"/> | ||
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/> | ||
</conditions> | ||
<description>Ignore Cache is a Glide Properties (records in the sys_properties table) field that impacts system performance. ‘ignore_cache’ is a way of avoiding database calls for commonly accessed property values. When it’s not handled carefully it can cause a system-wide cache flush leading to potentially severe performance degradation for anywhere from 5 to 30 minutes. In some very rare cases, the cache flush can even bring nodes down hard enough that the load balancer takes them offline, thus resulting in temporary session imbalance and causing hours of impact. | ||
| ||
The system stores system property values in server-side caches to avoid querying the database for configuration settings.” | ||
| ||
When you change a system property value, the system always flushes the cache for the sys_properties table. Use this field to determine whether to flush this property's value from all other server-side caches.</description> | ||
<documentation_url/> | ||
<finding_type>scan_finding</finding_type> | ||
<name>Ignore Cache : System Property</name> | ||
<priority>2</priority> | ||
<resolution_details>To prevent the cache flush in the future for the same system property, you can activate the Ignore cache i.e always select the ignore_cache checkbox. Almost always have 'ignore cache' set to "true" on 'sys_properties' records. Typically, you should only select the check box and enable ignoring the cache when you have a system property that changes more frequently than once a month, and the property value is only stored in the sys_properties table. | ||
| ||
Ignore cache = True: An update or insert of a system property will rebuild ONLY for that particular sys_property cache (yes, it is not a full ignore). | ||
| ||
Select the check box to ignore flushing some server-side caches, thus flushing only the cache for the sys_properties table and preserving the prior property value in all other caches. This option avoids the performance cost of flushing all caches and retrieving new property values.</resolution_details> | ||
<run_condition/> | ||
<score_max>100</score_max> | ||
<score_min>0</score_min> | ||
<score_scale>1</score_scale> | ||
<script><![CDATA[(function (engine) { | ||
|
||
// Add your code here | ||
|
||
})(engine);]]></script> | ||
<short_description>Disable 'Ignore cache' checkbox for commonly accessed system Properties</short_description> | ||
<sys_class_name>scan_table_check</sys_class_name> | ||
<sys_created_by>a.pandey</sys_created_by> | ||
<sys_created_on>2024-10-03 09:04:30</sys_created_on> | ||
<sys_id>cfe622458301d2100283b955eeaad366</sys_id> | ||
<sys_mod_count>0</sys_mod_count> | ||
<sys_name>Ignore Cache : System Property</sys_name> | ||
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package> | ||
<sys_policy/> | ||
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope> | ||
<sys_update_name>scan_table_check_cfe622458301d2100283b955eeaad366</sys_update_name> | ||
<sys_updated_by>a.pandey</sys_updated_by> | ||
<sys_updated_on>2024-10-03 09:04:30</sys_updated_on> | ||
<table>sys_properties</table> | ||
<use_manifest>false</use_manifest> | ||
</scan_table_check> | ||
<sys_translated_text action="delete_multiple" query="documentkey=cfe622458301d2100283b955eeaad366"/> | ||
</record_update> |
50 changes: 50 additions & 0 deletions
50
...67c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_f9f026c983cd92100283b955eeaad323.xml
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file is unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check"> | ||
<scan_table_check action="INSERT_OR_UPDATE"> | ||
<active>true</active> | ||
<advanced>false</advanced> | ||
<category>performance</category> | ||
<conditions table="sys_transform_map">run_business_rules!=true^EQ<item endquery="false" field="run_business_rules" goto="false" newquery="false" operator="!=" or="false" value="true"/> | ||
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/> | ||
</conditions> | ||
<description>Business rules validation directly on fields in Transform Maps is generally not considered a best practice, and instead, it is recommended to leverage other methods like Field Map Scripts or onBefore Transform Scripts for handling field-level data manipulation. | ||
Transform Maps usually deal with bulk data imports. Using business rules (which fire on each insert/update) during a data import can negatively impact performance, as business rules execute for every individual record transformation, which can slow down processing.</description> | ||
<documentation_url/> | ||
<finding_type>scan_finding</finding_type> | ||
<name>Transform Map Run Business Rule</name> | ||
<priority>3</priority> | ||
<resolution_details>Disable “Run Business Rules” | ||
| ||
Unless needed, the “Run Business Rules” checkbox should be unchecked as Post import additional business logic may leads to run via existing business rules, but this can increase | ||
import/processing times. | ||
| ||
Disabling this option will will stop the execution of the following and prevent the potential performance issue | ||
– Business Rules | ||
– Script engines (Approval Engine, Assignment rule Engine, Data policy Engine Field normalization Engine (CMDB), Role Engine, Execution Plan Engine, Workflow Engine, text Indexing Engine, Update Sync Engine(Update Set), Data Lookup Engine, Email notification) | ||
– Auditing</resolution_details> | ||
<run_condition/> | ||
<score_max>100</score_max> | ||
<score_min>0</score_min> | ||
<score_scale>1</score_scale> | ||
<script><![CDATA[(function (engine) { | ||
|
||
// Add your code here | ||
|
||
})(engine);]]></script> | ||
<short_description>Disable 'Run Business Rule' on Transform Map[sys_transform_map]</short_description> | ||
<sys_class_name>scan_table_check</sys_class_name> | ||
<sys_created_by>a.pandey</sys_created_by> | ||
<sys_created_on>2024-10-03 08:17:34</sys_created_on> | ||
<sys_id>f9f026c983cd92100283b955eeaad323</sys_id> | ||
<sys_mod_count>0</sys_mod_count> | ||
<sys_name>Transform Map Run Business Rule</sys_name> | ||
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package> | ||
<sys_policy/> | ||
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope> | ||
<sys_update_name>scan_table_check_f9f026c983cd92100283b955eeaad323</sys_update_name> | ||
<sys_updated_by>a.pandey</sys_updated_by> | ||
<sys_updated_on>2024-10-03 08:17:34</sys_updated_on> | ||
<table>sys_transform_map</table> | ||
<use_manifest>false</use_manifest> | ||
</scan_table_check> | ||
<sys_translated_text action="delete_multiple" query="documentkey=f9f026c983cd92100283b955eeaad323"/> | ||
</record_update> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't you want to have the instance scan resolve on the ones where the value is false to suggest moving to true?