Sn ap2024 instanescan 02 #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te if ''Run Business Rule' on Transform Map[sys_transform_map] is Disabled'
… if 'Ignore Cache' option is set as True. Since it has potential of causing system wide performance impact. If ‘ignore_cache’ is unchecked, then the entire Glide System cache will be flushed when a property is changed.
Included instance scan under 'Performance' cateogry to validate if ignore cache on system property table is set as True. This PR contains ne instance scan change along with readme.md file update
SapphicFire
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks for your submission. It appears that this pull request contains more files than described in the title. Please review and update the pull request to either remove the extra/unintended files or to update the description to be more comprehensive. Ensure your contributions are meaningful and adhere to the project’s standards. [If applicable: You can create a new branch on your forked repository to avoid accidental inclusions of new commits in the future.]. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.
Additionally, please clarify and potentially update your scan check to look for items where ignore_cache=false because this is seems to be matching for items with the desired configuration at present
Comment on lines
+6
to
+7
| <conditions table="sys_properties">ignore_cache=true^EQ<item endquery="false" field="ignore_cache" goto="false" newquery="false" operator="=" or="false" value="true"/> | ||
| <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/> |
There was a problem hiding this comment.
Wouldn't you want to have the instance scan resolve on the ones where the value is false to suggest moving to true?
|
Hi @astrid
Thanks for looking into this PR, I was expecting this though I was unsure
as while submitting PR I have created new branch to include one one change
for 'ignore_cache'.
Let me create a new branch and re-submit the PR.
Thanks
*Abhishek Pandey*
*+91 7869881249 || ***@***.*** ***@***.***>*
…On Thu, Oct 3, 2024 at 7:00 PM Astrid Sapphire ***@***.***> wrote:
Closed #116
<#116>
.
—
Reply to this email directly, view it on GitHub
<#116 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV5L6JOZLXRR7VOQEFOWJD3ZZU2GZAVCNFSM6AAAAABPJLXMWCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGUYDINJZG42DCNY>
.
You are receiving this because you authored the thread.Message ID:
<ServiceNowDevProgram/example-instancescan-checks/pull/116/issue_event/14504597417
@github.com>
|
|
Hi Team
I have re-submitted new PR as #117.
This PR should contain one 2 files
1. Instance scan check under performance category and
2. Readme.md file update with new instance scan check updated under
performance category.
Please ignore all other file I have updated in description, for some reason
it's not removing while submitting new PR.
Thanks
*Abhishek Pandey*
*+91 7869881249 || ***@***.*** ***@***.***>*
On Thu, Oct 3, 2024 at 7:26 PM Abhishek Pandey ***@***.***>
wrote:
… Hi @astrid
Thanks for looking into this PR, I was expecting this though I was unsure
as while submitting PR I have created new branch to include one one change
for 'ignore_cache'.
Let me create a new branch and re-submit the PR.
Thanks
*Abhishek Pandey*
*+91 7869881249 || ***@***.*** ***@***.***>*
On Thu, Oct 3, 2024 at 7:00 PM Astrid Sapphire ***@***.***>
wrote:
> Closed #116
> <#116>
> .
>
> —
> Reply to this email directly, view it on GitHub
> <#116 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AV5L6JOZLXRR7VOQEFOWJD3ZZU2GZAVCNFSM6AAAAABPJLXMWCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGUYDINJZG42DCNY>
> .
> You are receiving this because you authored the thread.Message ID:
> <ServiceNowDevProgram/example-instancescan-checks/pull/116/issue_event/14504597417
> @github.com>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included new instance scan under the performance cateogry to check if 'Ignore Cache' option is set as True on system property. Since it has the potential to cause system-wide performance impact. If ‘ignore_cache’ is unchecked, then the entire Glide System cache will be flushed when a property is changed.