-
Notifications
You must be signed in to change notification settings - Fork 683
Valid mobile number #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Valid mobile number #1569
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
This script is triggered when the phone field changes. | ||
It uses to validate the length of the phone number. If it exceeds the maximum length, it displays an error message and clears the field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Client Script: Validate Length | ||
// Table: sys_user | ||
// Type: onChange | ||
// Field: phone | ||
|
||
function onChange(control, oldValue, newValue, isLoading) { | ||
if (isLoading || newValue === '') return; | ||
|
||
if (newValue.length>12) { | ||
g_form.showFieldMsg('phone', 'Phone number should have a maximum of 12 charecters', 'error'); | ||
g_form.setValue('phone', ''); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if somebody uses spaces or dashes in the phone number?
+1 (800) 123-4567
is 17 characters and is a valid format for a phone number in the US. Have you considered using a regex to test the phone number? Additionally there is a dedicated field type for phone numbers, so can you provide some context around when you would use this script instead of the field?