Valid mobile number #1569
Closed
Valid mobile number #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiz0floyd
requested changes
Oct 30, 2024
| function onChange(control, oldValue, newValue, isLoading) { | ||
| if (isLoading || newValue === '') return; | ||
|
|
||
| if (newValue.length>12) { |
There was a problem hiding this comment.
What if somebody uses spaces or dashes in the phone number? +1 (800) 123-4567 is 17 characters and is a valid format for a phone number in the US. Have you considered using a regex to test the phone number? Additionally there is a dedicated field type for phone numbers, so can you provide some context around when you would use this script instead of the field?
|
I've requested changes in the script. I'm concerned that this is too simple to include in the code snippets repo as length is not a very robust method for validation of a phone number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is used to validate the length of the phone number. If it exceeds the maximum length, it displays an error message and clears the field.