Skip to content

[rb] Linting Updates #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/ruby/spec/bidi/logging_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Logging' do
Expand Down
3 changes: 2 additions & 1 deletion examples/ruby/spec/browsers/chrome_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@
'offline' => false,
'latency' => 100,
'download_throughput' => 200,
'upload_throughput' => 200)
'upload_throughput' => 200
)
end

it 'gets the browser logs' do
Expand Down
5 changes: 3 additions & 2 deletions examples/ruby/spec/browsers/edge_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@
'offline' => false,
'latency' => 100,
'download_throughput' => 200,
'upload_throughput' => 200)
'upload_throughput' => 200
)
end

it 'gets the browser logs' do
Expand Down Expand Up @@ -164,6 +165,6 @@ def driver_finder

def permission(name)
@driver.execute_async_script('callback = arguments[arguments.length - 1];' \
'callback(navigator.permissions.query({name: arguments[0]}));', name)['state']
'callback(navigator.permissions.query({name: arguments[0]}));', name)['state']
end
end
7 changes: 5 additions & 2 deletions examples/ruby/spec/browsers/safari_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

require 'spec_helper'

# rubocop:disable RSpec/MultipleDescribes
RSpec.describe 'Safari', exclusive: {platform: :macosx} do
describe 'Options' do
it 'basic options' do
Expand Down Expand Up @@ -33,10 +34,12 @@
end
end

RSpec.describe 'Safari Technology Preview', skip: "This test is being skipped as GitHub Actions have no support for Safari Technology Preview" do
RSpec.describe 'Safari Technology Preview', skip: 'This test is being skipped as GitHub Actions ' \
'have no support for Safari Technology Preview' do
it 'sets the technology preview' do
Selenium::WebDriver::Safari.technology_preview!
local_driver = Selenium::WebDriver.for :safari
expect(local_driver.capabilities.browser_name).to eq 'Safari Technology Preview'
end
end
end
# rubocop:enable RSpec/MultipleDescribes
2 changes: 2 additions & 0 deletions examples/ruby/spec/drivers/http_client_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'HTTP Client' do
Expand Down
2 changes: 2 additions & 0 deletions examples/ruby/spec/hello/hello_selenium.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'selenium-webdriver'

driver = Selenium::WebDriver.for :chrome
Expand Down
2 changes: 2 additions & 0 deletions examples/ruby/spec/interactions/browser_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Browser' do
Expand Down
2 changes: 2 additions & 0 deletions examples/ruby/spec/interactions/navigation_spec.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# frozen_string_literal: true

require 'spec_helper'

RSpec.describe 'Browser' do
Expand Down
Loading