Skip to content

[rb] Linting Updates #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2025
Merged

[rb] Linting Updates #2297

merged 4 commits into from
May 3, 2025

Conversation

shbenzer
Copy link
Contributor

@shbenzer shbenzer commented May 3, 2025

User description

Fix linting failures in repo

Description

general linting upgrades

Motivation and Context

Cleaner CI

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Enhancement


Description

  • Add frozen string literal pragma to Ruby spec files

  • Minor formatting improvements for consistency

  • No functional or logic changes introduced


Changes walkthrough 📝

Relevant files
Formatting
safari_spec.rb
Add newline for formatting consistency                                     

examples/ruby/spec/browsers/safari_spec.rb

  • Added newline at end of file for formatting consistency
  • No code logic changes
  • +1/-1     
    Enhancement
    http_client_spec.rb
    Add frozen string literal pragma to file                                 

    examples/ruby/spec/drivers/http_client_spec.rb

  • Added # frozen_string_literal: true pragma at the top
  • No code logic changes
  • +2/-0     
    hello_selenium.rb
    Add frozen string literal pragma to file                                 

    examples/ruby/spec/hello/hello_selenium.rb

  • Added # frozen_string_literal: true pragma at the top
  • No code logic changes
  • +2/-0     
    browser_spec.rb
    Add frozen string literal pragma to file                                 

    examples/ruby/spec/interactions/browser_spec.rb

  • Added # frozen_string_literal: true pragma at the top
  • No code logic changes
  • +2/-0     
    navigation_spec.rb
    Add frozen string literal pragma to file                                 

    examples/ruby/spec/interactions/navigation_spec.rb

  • Added # frozen_string_literal: true pragma at the top
  • No code logic changes
  • +2/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    netlify bot commented May 3, 2025

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 57554c1

    Copy link
    Contributor

    qodo-merge-pro bot commented May 3, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented May 3, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @shbenzer shbenzer merged commit 208e584 into SeleniumHQ:trunk May 3, 2025
    7 of 10 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant