Skip to content

Remove outdated Julia version checks #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Remove outdated Julia version checks #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions test/basictests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,24 +198,22 @@ end
test_interface(SparspakFactorization(), prob1, prob2)
end

if VERSION >= v"1.9"
@testset "FastLAPACK Factorizations" begin
A1 = A / 1
b1 = rand(n)
x1 = zero(b)
A2 = A / 2
b2 = rand(n)
x2 = zero(b)
@testset "FastLAPACK Factorizations" begin
A1 = A / 1
b1 = rand(n)
x1 = zero(b)
A2 = A / 2
b2 = rand(n)
x2 = zero(b)

prob1 = LinearProblem(A1, b1; u0 = x1)
prob2 = LinearProblem(A2, b2; u0 = x2)
test_interface(LinearSolve.FastLUFactorization(), prob1, prob2)
test_interface(LinearSolve.FastQRFactorization(), prob1, prob2)
prob1 = LinearProblem(A1, b1; u0 = x1)
prob2 = LinearProblem(A2, b2; u0 = x2)
test_interface(LinearSolve.FastLUFactorization(), prob1, prob2)
test_interface(LinearSolve.FastQRFactorization(), prob1, prob2)

# TODO: Resizing tests. Upstream doesn't currently support it.
# Need to be absolutely certain we never segfault with incorrect
# ws sizes.
end
# TODO: Resizing tests. Upstream doesn't currently support it.
# Need to be absolutely certain we never segfault with incorrect
# ws sizes.
end

test_algs = [
Expand All @@ -226,15 +224,15 @@ end
LinearSolve.defaultalg(prob1.A, prob1.b)
]

if VERSION >= v"1.9" && LinearSolve.usemkl
if LinearSolve.usemkl
push!(test_algs, MKLLUFactorization())
end

@testset "Concrete Factorizations" begin
for alg in test_algs
@testset "$alg" begin
test_interface(alg, prob1, prob2)
VERSION >= v"1.9" && test_interface(alg, prob3, prob4)
test_interface(alg, prob3, prob4)
end
end
if LinearSolve.appleaccelerate_isavailable()
Expand Down
2 changes: 1 addition & 1 deletion test/sparse_vector.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ linsolve = init(prob);
H = hess_mat' * hess_mat
prob = LinearProblem(H, hess_mat' * grad_vec)
linsolve = init(prob, CholeskyFactorization())
VERSION >= v"1.8" && @test solve!(linsolve).u ≈ H \ Array(hess_mat' * grad_vec)
@test solve!(linsolve).u ≈ H \ Array(hess_mat' * grad_vec)

# https://github.com/SciML/LinearSolve.jl/issues/614
A = sprand(ComplexF64, 10, 10, 0.5)
Expand Down
Loading