Skip to content

Remove outdated Julia version checks #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

ChrisRackauckas
Copy link
Member

Summary

  • Removed version checks for Julia v1.8 and v1.9 since Julia v1.10 is now the LTS
  • Removed associated test code that was conditional on these older versions

Changes

  • Removed FastLAPACK Factorizations testset (v1.9 gated)
  • Removed MKLLUFactorization test (v1.9 gated)
  • Removed test_interface call for prob3/prob4 (v1.9 gated)
  • Removed Cholesky solve test (v1.8 gated)

Test plan

  • Tests pass locally
  • CI passes

🤖 Generated with Claude Code

Since Julia v1.10 is now the LTS, version checks for v1.8 and v1.9 are always true.
Keep the code that was inside these checks but remove the conditionals themselves.

- Keep FastLAPACK Factorizations testset (was v1.9 gated)
- Keep MKLLUFactorization test, only remove VERSION check
- Keep test_interface call for prob3/prob4 (was v1.9 gated)
- Keep Cholesky solve test (was v1.8 gated)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@ChrisRackauckas ChrisRackauckas force-pushed the remove-old-version-checks branch from 8d54259 to 5c6ff0f Compare July 28, 2025 00:33
@ChrisRackauckas ChrisRackauckas merged commit 0427d49 into main Jul 28, 2025
36 of 40 checks passed
@ChrisRackauckas ChrisRackauckas deleted the remove-old-version-checks branch July 28, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants