-
Notifications
You must be signed in to change notification settings - Fork 37
add audit logging for signup action + tests #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
16657a7
add audit log schema
pxtrickhoxng d2a952a
add audit util + login audit log
pxtrickhoxng 3a55b4d
move audit-log imports to top
pxtrickhoxng 077876a
Add test to ensure login succeeds even if audit logging fails + minor…
pxtrickhoxng 2a840aa
change audit file names
pxtrickhoxng d5f979d
fix audit import names
pxtrickhoxng 7570ec9
fix audit import names (2)
pxtrickhoxng 26b58e0
remove unnecessary audit details
pxtrickhoxng 70a83c3
move login audit log tests to correct file and update helper functions
pxtrickhoxng 8e73193
remove async from audit log at login endpoint
pxtrickhoxng 4472600
remove audit util function + fix file names
pxtrickhoxng 52eb9c8
Add audit logging on user registration + corresponding tests
pxtrickhoxng 219683a
fix audit log to use correct user id
pxtrickhoxng df6dfac
Update test to ensure audit log entry on successful signup
pxtrickhoxng 22d5236
add error logging on failed sign-up audit + minor test fixes
pxtrickhoxng 87cb113
Rebase
pxtrickhoxng d695c91
fix tests
pxtrickhoxng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thnk we can move the tests into the below section, we already have it for /POST login
Clark/test/api/Auth.js
Line 146 in 5b59f83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should already be resolved on most recent commit, [0020286]