add audit logging for signup action + tests#1680
Merged
evanugarte merged 17 commits intoSCE-Development:devfrom Jul 1, 2025
Merged
add audit logging for signup action + tests#1680evanugarte merged 17 commits intoSCE-Development:devfrom
evanugarte merged 17 commits intoSCE-Development:devfrom
Conversation
evanugarte
reviewed
Jun 19, 2025
| userId: user._id, | ||
| action: AuditLogActions.SIGN_UP, | ||
| details: {email: req.body.email} | ||
| }); |
Collaborator
There was a problem hiding this comment.
Suggested change
| }); | |
| }).catch(logger.error); |
| }); | ||
| }); | ||
|
|
||
| describe('/POST login', () => { |
evanugarte
reviewed
Jun 19, 2025
Comment on lines
+215
to
+218
| const auditEntry = await AuditLog.findOne({ | ||
| action: AuditLogActions.SIGN_UP, | ||
| 'details.email': registerPayload.email | ||
| }).lean(); |
Collaborator
There was a problem hiding this comment.
can we do the below instead, since one document should exist in the collection anyway
Suggested change
| const auditEntry = await AuditLog.findOne({ | |
| action: AuditLogActions.SIGN_UP, | |
| 'details.email': registerPayload.email | |
| }).lean(); | |
| const auditEntry = await AuditLog.findOne().lean(); |
… util and schema changes
pxtrickhoxng
force-pushed
the
audit-on-signup
branch
from
0ad0980 to
87cb113
Compare
evanugarte
approved these changes
Jun 25, 2025
weslayer
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit logs userId and email at /register endpoint. Added two tests: one verifying audit log functionality, and another to ensure that users are still able to signup even if audit log fails.
#1669 Should be merged first.