ecdsa: der: use impl EncodeValue/DecodeValue on SignatureRef
#965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Those aren't really "internals": they're part of the public API, though this is perhaps more really idiomatic with how the rest of the library works. Notably this doesn't really reduce code size. |
ecdsa: use `der::Result` ecdsa: cargo clippy
dishmaker
force-pushed
the
dishmaker/ecdsa_der_decode_encode_value
branch
from
6ffb2a6 to
2591f5c
Compare
tarcieri
reviewed
Jun 6, 2025
Co-authored-by: Tony Arcieri <[email protected]>
tarcieri
reviewed
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we avoid using internals of
der:der::SliceWriterder::SliceReadertag.assert_eqwriter.sequence