Skip to content

der: remove generic <T> from Reader::finish #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dishmaker
Copy link
Contributor

@dishmaker dishmaker commented May 12, 2025

Depends on:

Before:

./formats$ cargo llvm-lines -p der --all-features | head -n 10
  Lines                Copies              Function name
  -----                ------              -------------
  68510                1007                (TOTAL)
   6422 (9.4%,  9.4%)    29 (2.9%,  2.9%)  der::asn1::any::AnyRef::decode_as
   3334 (4.9%, 14.2%)    33 (3.3%,  6.2%)  <der::reader::slice::SliceReader as der::reader::Reader>::finish
   2310 (3.4%, 17.6%)    10 (1.0%,  7.1%)  der::asn1::integer::value_cmp

After:

./formats$ cargo llvm-lines -p der --all-features | head -n 10
  Lines                Copies             Function name
  -----                ------             -------------
  65769                975                (TOTAL)
   6879 (10.5%, 10.5%)  29 (3.0%,  3.0%)  der::asn1::any::AnyRef::decode_as
   2310 (3.5%, 14.0%)   10 (1.0%,  4.0%)  der::asn1::integer::value_cmp
   1768 (2.7%, 16.7%)    1 (0.1%,  4.1%)  der::tag::_::<impl arbitrary::Arbitrary for der::tag::Tag>::try_size_hint::{{closure}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant