fix: collecting messages from agent #544
Merged
+35
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatejcz
force-pushed
the
jm/fix/collecting_messages_from_agent
branch
from
161b696 to
1c27c7d
Compare
maciejmajek
reviewed
Apr 28, 2025
| @@ -184,33 +184,36 @@ def run_next(self, agent: CompiledStateGraph) -> None: | |||
| tool_calls_num = 0 | |||
|
|
|||
| ts = time.perf_counter() | |||
| prev_count: int = 0 | |||
| for state in agent.stream( | |||
There was a problem hiding this comment.
Why exactly are we using stream instead of invoke which returns all the messages under 'messages' key?
There was a problem hiding this comment.
so that we get partial results when Recursion Limit throws an error. I don't think it can be done, when using invoke() as it return output when whole execution is over
jmatejcz
force-pushed
the
jm/fix/collecting_messages_from_agent
branch
from
1c27c7d to
378e179
Compare
maciejmajek
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fix collecting messages from agent, described in issue linked below.
Proposed Changes
in agent.stream() loop there is now counter for how many messages were already received and on each iteration only the [received_count: ] messages are appended.
Also fixed import issue in openset 161b696
which was introduced in some other refactors
Issues
#543
Testing
src/rai_bench/rai_bench/examples/test_models.pyin debug mode.Check if all unique(ids of messages) messages from state variable are appended to messages properly.
Do this for both tool calling agent and manipulaiton_o3de (change in
src/rai_bench/rai_bench/examples/test_models.pyselected benchamrk if needed).