-
Notifications
You must be signed in to change notification settings - Fork 407
fix(ROS2TFClient): Use correct action type for ROS2 tf2_web_republisher #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the ROS2 version of tf2-web-republisher, the correct Action name should be tf2_web_republisher_interfaces/action/TFSubscription. Fixing this will allow PointCloud2 to be displayed correctly on the web page. This change has been tested on ROS2 Kilted, Ubuntu 24.04 and works for me.
@EzraBrooks this is a breaking change for ROS1. Time to branch of for ROS1? |
Hi, @MatthijsBurgh,thank you for your feedback,I'd like to think that my change was made exclusively within the ROS2TFClient class, which is intended for ROS 2 environments. The original TFClient for ROS 1 remains untouched. |
roslibjs/examples/ros2_action_client.html Line 46 in 0f6d12a
This example doesn't include the |
Co-authored-by: Matthijs van der Burgh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the ROS2TFClient to use the correct action type for ROS2 tf2_web_republisher, changing from the hardcoded ROS1-style action type to the proper ROS2 interface specification.
- Updates the action type from
tf2_web_republisher_msgs/TFSubscription
totf2_web_republisher_interfaces/TFSubscription
- Resolves compatibility issues preventing PointCloud2 visualizations from displaying correctly
- Tested on ROS2 Kilted with Ubuntu 24.04
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
In the ROS2 version of tf2-web-republisher, the correct Action name should be tf2_web_republisher_interfaces/action/TFSubscription. Fixing this will allow PointCloud2 to be displayed correctly on the web page. This change has been tested on ROS2 Kilted, Ubuntu 24.04 and works for me.
Public API Changes
None
Description
The ROS2TFClient component currently uses a hardcoded action type (tf2_web_republisher_msgs/TFSubscription) This makes the client incompatible with standard ROS 2 tf2_web_republisher, which expect the action type to be tf2_web_republisher_interfaces/action/TFSubscription.
This commit corrects the hardcoded action type to the proper ROS 2 version. As a result, TF-dependent visualizations like PointCloud2 can now be displayed correctly on a web page when using a ROS 2 backend, resolving a critical compatibility issue.
This change has been tested and verified on ROS 2 Kilted with Ubuntu 24.04.
Resolves #948