Statically type EventEmitter events #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
approved these changes
Nov 7, 2025
| handleMessage(message: RosbridgeMessage) { | ||
| if (isRosbridgePublishMessage(message)) { | ||
| this.emit(message.topic, message.msg); | ||
| this.emit(message.topic, message); |
Contributor
There was a problem hiding this comment.
Mostly curious about this one -- was it a bug?
Collaborator
Author
There was a problem hiding this comment.
Not a bug as much as a weird layer of indirection - you can see in Topic that it was (internally, not exposed to users) behaving slightly differently than the other classes. It was handling just the inner msg member instead of the whole message from rosbridge. By moving the place where .msg was being accessed, the API became consistent.
This rooted out another few bits of weirdness.
EzraBrooks
force-pushed
the
statically-typed-events
branch
from
3ca9d39 to
1ab4df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
none
Description
Routed out another few bits of weirdness by statically typing the event interfaces of each class. Funnily enough, this revealed that some of them were just not being used at all and could be removed.