Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check instructions length before setting option value #1196

Merged
merged 3 commits into from
Feb 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Fixed

- Fixed sidebar not correctly reopening (#1196)

## [0.29.0] - 2025-02-06

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/components/Menus/Sidebar/SidebarBar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const SidebarBar = (props) => {
const isMobile = useMediaQuery({ query: MOBILE_MEDIA_QUERY });

const expandPopOut = () => {
const option = instructions ? "instructions" : "file";
const option = instructions.length > 0 ? "instructions" : "file";
toggleOption(option);
if (window.plausible) {
// TODO: Make dynamic events for each option or rename this event
Expand Down
8 changes: 7 additions & 1 deletion src/components/Menus/Sidebar/SidebarBar.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,13 @@ describe("SidebarBar", () => {
<SidebarBar
menuOptions={menuOptions(true)}
toggleOption={toggleOption}
instructions
instructions={[
{
title: "My testing title",
content: "My testing content",
quiz: false,
},
]}
/>
</Provider>,
);
Expand Down
Loading