Check instructions length before setting option value #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebenstead
temporarily deployed
to
previews/1196/merge
GitHub Actions
Inactive
jamiebenstead
temporarily deployed
to
previews/1196/merge
GitHub Actions
Inactive
danhalson
reviewed
Feb 21, 2025
| let option = "file"; | ||
| if (instructions.length > 0) { | ||
| option = "instructions"; | ||
| } |
There was a problem hiding this comment.
you could make this a one liner again with
const option = instructions.length > 0 ? "instructions" : "file";
but happy with it either way 😄
danhalson
approved these changes
Feb 21, 2025
Merged
jamiebenstead
added a commit
that referenced
this pull request
Feb 21, 2025
## What's Changed * Check instructions length before setting option value by @jamiebenstead in #1196 **Full Changelog**: v0.29.0...v0.29.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes
I found that
const option = instructions ? "instructions" : "file";was always being set to true because it was receiving an empty array