Skip to content

[bsp][renesas]add EK-RA2A1 support #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 24, 2025
Merged

[bsp][renesas]add EK-RA2A1 support #10610

merged 6 commits into from
Aug 24, 2025

Conversation

CYFS3
Copy link
Contributor

@CYFS3 CYFS3 commented Aug 17, 2025

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

添加EK-RA2A1的支持，目前使用的是FSP6.0版本
存在的问题：
当使用FSP重新生成代码的时候，会在当前目录重新生成bsp_linker_info.h,直接使用env编译的话需要手动删除，keil没有影响

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP action github action yml imporve BSP: Renesas BSP related with Renesas labels Aug 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 17, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: kurisaW

Changed Files (Click to expand)
  • bsp/renesas/libraries/HAL_Drivers/config/drv_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/adc_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/can_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/dac_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/pwm_config.h
  • bsp/renesas/libraries/HAL_Drivers/config/ra2a1/uart_config.h
  • bsp/renesas/libraries/Kconfig
  • bsp/renesas/ra2a1-ek/.api_xml
  • bsp/renesas/ra2a1-ek/.config
  • bsp/renesas/ra2a1-ek/.gitignore
  • bsp/renesas/ra2a1-ek/.ignore_format.yml
  • bsp/renesas/ra2a1-ek/.secure_azone
  • bsp/renesas/ra2a1-ek/.secure_rzone
  • bsp/renesas/ra2a1-ek/.secure_xml
  • bsp/renesas/ra2a1-ek/.settings/standalone.prefs
  • bsp/renesas/ra2a1-ek/EventRecorderStub.scvd
  • bsp/renesas/ra2a1-ek/Kconfig
  • bsp/renesas/ra2a1-ek/README.md
  • bsp/renesas/ra2a1-ek/SConscript
  • bsp/renesas/ra2a1-ek/SConstruct
  • bsp/renesas/ra2a1-ek/board/Kconfig
  • bsp/renesas/ra2a1-ek/board/SConscript
  • bsp/renesas/ra2a1-ek/board/board.h
  • bsp/renesas/ra2a1-ek/board/ports/SConscript
  • bsp/renesas/ra2a1-ek/board/ports/gpio_cfg.h
  • bsp/renesas/ra2a1-ek/buildinfo.gpdsc
  • bsp/renesas/ra2a1-ek/configuration.xml
  • bsp/renesas/ra2a1-ek/docs/picture/PixPin_2025-08-17_23-14-53.png
  • bsp/renesas/ra2a1-ek/docs/picture/PixPin_2025-08-17_23-17-25.png

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-08-23 11:26 CST)

  • ⌛ Rbb666 Pending Review
  • ⌛ kurisaW Pending Review
  • ⌛ supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@CYFS3 CYFS3 changed the title add EK-RA2A1 support [bsp][renreas]add EK-RA2A1 support Aug 17, 2025
@CYFS3 CYFS3 changed the title [bsp][renreas]add EK-RA2A1 support [bsp][renesas]add EK-RA2A1 support Aug 17, 2025
@CYFS3
Copy link
Contributor Author

CYFS3 commented Aug 17, 2025

PixPin_2025-08-18_00-54-06

Rbb666
Rbb666 reviewed Aug 18, 2025
View reviewed changes
bsp/renesas/ra2a1-ek/template.uvguix.CYFSybW Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余的中间文件可以删除

bsp/renesas/ra2a1-ek/via/rasc_armasm.via Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

via文件夹应该也是中间产物，可以删掉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

via可以删掉，然后keil里的这段指令也请对应删除，这应该是自动启动rasc的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

via可以删掉，然后keil里的这段指令也请对应删除，这应该是自动启动rasc的

via每次生成代码就会自己生成，我就没删，虽然keil那边可以直接填指令，但是我想着他每次生成都会重新生成我就没删了
PixPin_2025-08-18_11-05-03

bsp/renesas/ra2a1-ek/rtconfig.py
POST_ACTION = OBJCPY + ' -O ihex $TARGET rtthread.hex\n' + SIZE + ' $TARGET \n'
# POST_ACTION += OBJCPY + ' -O binary $TARGET rtthread.bin\n' + SIZE + ' $TARGET \n'

elif PLATFORM == 'armclang':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有验证过的工具链可以删除，保留验证过即可

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有验证过的工具链可以删除，保留验证过即可

好的

bsp/renesas/ra2a1-ek/board/ports/SConscript Outdated

src = []

if GetDepend(['BSP_USING_RW007']):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证过吗？没有的话可以先删掉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证过吗？没有的话可以先删掉

好的

@CYFS3 CYFS3 requested review from Rbb666 and kurisaW August 18, 2025 12:39
@CYFS3 CYFS3 mentioned this pull request Aug 18, 2025
Merged
10 tasks
@CYFS3
Copy link
Contributor Author

CYFS3 commented Aug 20, 2025

PixPin_2025-08-20_21-35-19 使用脚本把每次会重新生成的bsp_linker_info.h 自动删除，但是不清楚后续的配置中这个文件会不会新的东西添加进来。

kurisaW
kurisaW reviewed Aug 21, 2025
View reviewed changes
kurisaW
kurisaW reviewed Aug 21, 2025
View reviewed changes
bsp/renesas/ra2a1-ek/SConstruct

# include drivers
objs.extend(SConscript(os.path.join(libraries_path_prefix, 'HAL_Drivers', 'SConscript')))

Copy link
Member

@kurisaW kurisaW Aug 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一般不同版本fsp生成后会导致启动函数那发生变化，可以参考下面这个处理加一段脚本，你的这段关于bsp_linker_info.h的处理也可以放在这段代码处理这，效果就是编译前会执行这段脚本

rt-thread/bsp/renesas/ra6m3-hmi-board/SConstruct

Line 48 in 882d195

def startup_check():

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一般不同版本fsp生成后会导致启动函数那发生变化，可以参考下面这个处理加一段脚本，你的这段关于bsp_linker_info.h的处理也可以放在这段代码处理这，效果就是编译前会执行这段脚本

rt-thread/bsp/renesas/ra6m3-hmi-board/SConstruct

Line 48 in 882d195

def startup_check():

我把这个内容补充在这个函数中

@Rbb666 Rbb666 closed this Aug 23, 2025
@Rbb666 Rbb666 reopened this Aug 23, 2025
@Rbb666 Rbb666 merged commit 88d0eb0 into RT-Thread:master Aug 24, 2025
120 of 123 checks passed
@CYFS3 CYFS3 deleted the ek-ra2a1 branch August 26, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurisaW kurisaW kurisaW left review comments

@Rbb666 Rbb666 Rbb666 approved these changes

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

Assignees
No one assigned
Labels
action github action yml imporve BSP: Renesas BSP related with Renesas BSP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CYFS3 @Rbb666 @kurisaW