Quick find tool bar #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable automatic QuickFindDialog creation when SyntaxpainConfiguration has null dialog factory
…s may implement their own translation inline initComponents because re-calling it or overriding it and trying to access instance fields could lead to unexpected behavior; users should put the contents of their overrides in their constructors add QuickFindToolBar::dismissOnFocusLost, allowing subclasses to control whether the toolbar is dismissed when it loses focus remove escape-to-close keybind from QuickFindToolBar; users may add their own keybinds
|
ready |
This was referenced Sep 23, 2025
Closed
ix0rai
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuickFindToolBarfromQuickFindDialogQuickFindDialogcreation whenSyntaxpainConfigurationhasnulldialog factoryinitComponents()because it could lead to unexpected behavior due to it being called from the constructortranslate()as translation was not supported and subclasses can implement their own translationSupersede #4.
Facilitates QuiltMC/enigma#304 superseding #5
Can be manually tested by publishing locally, then on QuiltMC/enigma#304 running
:enigma-swing:completeTestGui.