Skip to content

Conversation

supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Sep 23, 2025

based on #303 rebased

currently requires you publish QuiltMC/syntaxpain#6 locally updates syntaxpain to 0.2.0

  • converts EnigmaQuickFindDialog to EnigmaQuickFindToolBar
  • disables syntaxpane's default QuickFindDialog and uses an EnigmaQuickFindToolbar in EditorPane instead
    • EditorPanel keybinds are useable with quickfind open
    • quickfind doesn't cover any part of EditorPanel's editor
  • supersedes Persistent quick-find syntaxpain#5
  • makes the EDITOR_QUICK_FIND keybind configurable.

@supersaiyansubtlety supersaiyansubtlety self-assigned this Sep 23, 2025
@supersaiyansubtlety supersaiyansubtlety added user interface affects the enigma ui wip in progress refactor improvements that don't impact functionality labels Sep 23, 2025
@supersaiyansubtlety
Copy link
Member Author

supersaiyansubtlety commented Sep 23, 2025

ready once #303 and QuiltMC/syntaxpain#6 are merged

@supersaiyansubtlety supersaiyansubtlety removed the wip in progress label Sep 23, 2025
@supersaiyansubtlety supersaiyansubtlety mentioned this pull request Sep 28, 2025
13 tasks
@ix0rai ix0rai self-requested a review October 8, 2025 01:42
convert EnigmaQuickFindDialog to EnigmaQuickFindToolBar
add an EnigmaQuickFindToolBar as a child in EditorPanel
- EditorPanel keybinds are useable with quickfind open
- quickfind doesn't cover any part of EditorPanel's editor
retranslate EditorPanel's EnigmaQuickFindToolBar
implement EnigmaQuickFindToolBar translation (copied from old QuickFindDialog::translate)
add QuickFindDialog persistentCheckBox and closeButton
@supersaiyansubtlety supersaiyansubtlety marked this pull request as ready for review October 11, 2025 14:47
@supersaiyansubtlety
Copy link
Member Author

ready!

Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, i love how much better this version feels than the old one. just a couple nitpicks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor improvements that don't impact functionality user interface affects the enigma ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants