Skip to content

Improve keybinds #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: develop/2.7
Choose a base branch
from
Open

Improve keybinds #303

wants to merge 13 commits into from

Conversation

supersaiyansubtlety
Copy link
Member

Uses InputMaps+ActionMaps instead of KeyListeners for KeyBinds.

Also:

  • fixes a bug where changing a keybind via the ui would add a new keybind instead of replacing the old one (isNewCombination was inverted)
  • simplifies EditorPanel ctrl+click to navigate logic
  • changes default EDITOR_SHOW_CALLS binding to ctrl + alt + c because ctrl + c is copy on windows (before it was both copying and showing calls)

@supersaiyansubtlety
change default KeyBinds.EDITOR_SHOW_CALLS to ctrl + alt + c because c…
a4174a6 
…trl + c is copy on windows

use InputMap instead of KeyListener in EditorPanel and eliminate EditorPopupMenu::handleKeyEvent
simplify EditorPanel ctrl + click to navigate logic
@supersaiyansubtlety
add all KeyBind combinations in InputUtil::putKeybindAction
531a6b3 
fix inverted EditKeyBindDialog::isNewCombination
@supersaiyansubtlety
putKeybindAction -> putKeyBindAction
ff4fbc3
@supersaiyansubtlety
use InputMap instead of key listener in EnigmaQuickFindDialogue
f6960cb
@supersaiyansubtlety
separate MULTILINE_DIALOG_SAVE from KeyBinds.DIALOG_SAVE
0e8c8bb 
use InputMap instead of key listener in JavadocDialog
@supersaiyansubtlety
use InputMap instead of key listener in ClassSelector
a763d3a
@supersaiyansubtlety
use InputMap instead of key listener in ChangeDialog
3bcff3a
@supersaiyansubtlety
use InputMap instead of key listener in SearchDialog
3b80b51
@supersaiyansubtlety
use InputMap instead of key listener in StructureDocker
a04f6c6
@supersaiyansubtlety
use InputMap instead of key listener in ConvertingTextField
32fe644
@supersaiyansubtlety
use InputMap instead of key listener in EditorTabbedPane
42af866
@supersaiyansubtlety
javadoc and deprecate KeyBind::matches
35fd4d9
@supersaiyansubtlety
merge InputUtil into GuiUtil
d073a8b
@supersaiyansubtlety supersaiyansubtlety self-assigned this Sep 22, 2025
@supersaiyansubtlety supersaiyansubtlety added the user interface affects the enigma ui label Sep 22, 2025
@ix0rai ix0rai added bug Something isn't working refactor improvements that don't impact functionality labels Sep 23, 2025
@supersaiyansubtlety supersaiyansubtlety mentioned this pull request Sep 23, 2025
Draft
@ix0rai ix0rai self-requested a review October 4, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai Awaiting requested review from ix0rai

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels
bug Something isn't working refactor improvements that don't impact functionality user interface affects the enigma ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supersaiyansubtlety @ix0rai