Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove redundant CIBW_BEFORE_BUILD #631

Merged

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Jun 19, 2024

Types of changes

The build system should define all required build components and make them available at wheel build time. As this pip install step is not required, remove CIBW_BEFORE_BUILD.

From the cibuildwheel docs https://cibuildwheel.pypa.io/en/stable/options/#before-build

If dependencies are required to build your wheel (for example if you include a header from a Python module), instead of using this command, we recommend adding requirements to a pyproject.toml file's build-system.requires array instead.

Motivation and context / Related issue

Follow up PR to PR #629

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • [N/A] I have added the PR and Issue fix to the RELEASES.md file.

* The build system should define all required build components and
  make them available at wheel build time. As this pip install step
  is not required, remove CIBW_BEFORE_BUILD.

  From the docs https://cibuildwheel.pypa.io/en/stable/options/#before-build

  > If dependencies are required to build your wheel (for example if you
  > include a header from a Python module), instead of using this command,
  > we recommend adding requirements to a pyproject.toml file's
  > build-system.requires array instead.
@rflamary rflamary merged commit 36b4c0a into PythonOT:master Jun 19, 2024
16 of 17 checks passed
@matthewfeickert matthewfeickert deleted the ci/remove-extra-pip-install branch June 19, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants