Skip to content

Commit 36b4c0a

Browse files
authoredJun 19, 2024··
[CI] Remove redundant CIBW_BEFORE_BUILD (#631)
* The build system should define all required build components and make them available at wheel build time. As this pip install step is not required, remove CIBW_BEFORE_BUILD. From the docs https://cibuildwheel.pypa.io/en/stable/options/#before-build > If dependencies are required to build your wheel (for example if you > include a header from a Python module), instead of using this command, > we recommend adding requirements to a pyproject.toml file's > build-system.requires array instead.
1 parent 61d751b commit 36b4c0a

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed
 

‎.github/workflows/build_wheels_weekly.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
push:
88
branches:
99
- "master"
10-
10+
1111
jobs:
1212
build_wheels:
1313
name: ${{ matrix.os }}
@@ -40,7 +40,6 @@ jobs:
4040
- name: Build wheels
4141
env:
4242
CIBW_SKIP: "pp*-win* pp*-macosx* cp2* pp* cp*musl* cp36* *i686" # remove pypy on mac and win (wrong version)
43-
CIBW_BEFORE_BUILD: "pip install numpy cython"
4443
CIBW_ARCHS_LINUX: auto aarch64 # force aarch64 with QEMU
4544
CIBW_ARCHS_MACOS: x86_64 universal2 arm64
4645
run: |

‎Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ aautopep8 :
8585
autopep8 -air test ot examples --jobs -1
8686

8787
wheels :
88-
CIBW_BEFORE_BUILD="pip install numpy cython" cibuildwheel --platform linux --output-dir dist
88+
cibuildwheel --platform linux --output-dir dist
8989

9090
dist : wheels
9191
$(PYTHON) setup.py sdist

0 commit comments

Comments
 (0)
Please sign in to comment.