-
Notifications
You must be signed in to change notification settings - Fork 49
Sync changes for release pipeline #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SteveL-MSFT
wants to merge
17
commits into
PowerShell:main
Choose a base branch
from
SteveL-MSFT:v3.2-p4-merge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change to use new repo
update sub name ---- #### AI description (iteration 1) #### PR Classification This pull request is a configuration update that modifies the Azure subscription reference in a CI/CD pipeline. #### PR Summary This update changes the Azure subscription value in the pipeline configuration to ensure that the GitHub Actions task uses the correct credentials during execution. - `.pipelines/DSC-Official.yml`: Replaced the `azureSubscription` value from `az-blob-cicd-infra` to `PowerShell-CICD-Feed-Access` in multiple Azure CLI tasks. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
change to installing musl-gcc ---- #### AI description (iteration 1) #### PR Classification This PR updates the build configuration by switching the installed compiler from gcc-multilib to musi-gcc and adjusting the build projects list. #### PR Summary The changes update the installation command in the pipeline and modify the build script to include the current directory in the project sequence. - `/.pipelines/DSC-Official.yml`: Replace installing gcc-multilib with installing musi-gcc and comment out the original command. - `/build.ps1`: Add the current directory (`"."`) to the list of build projects. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
don't update rust if used in ADO ---- #### AI description (iteration 1) #### PR Classification Bug fix to prevent the rust toolchain from updating in an ADO environment. #### PR Summary This pull request updates the build script to ensure that rust is not updated when running in an ADO environment. - In `build.ps1`, the rust update condition is modified to run only if the `$usingADO` flag (set based on the `TF_BUILD` environment variable) is false. - In `build.ps1`, the `$usingADO` variable is moved to a global scope, removing its redundant local assignment in the test block. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
don't run msrustup at all within ADO ---- #### AI description (iteration 1) #### PR Classification This PR updates the build script to disable the execution of msrustup in ADO environments. #### PR Summary The pull request modifies `/build.ps1` to ensure that msrustup is not run when the build is executed within ADO. It introduces an early exit when the ADO flag is set and simplifies the rust toolchain selection and update logic. - `build.ps1`: Adds a conditional branch that breaks out when `$usingADO` is true, preventing msrustup execution. - `build.ps1`: Removes the fallback assignment of `$rustup` to `echo` and adjusts the update condition for clarity and proper toolchain selection. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
copilot messed up my script last PR, the `return` exited the script so nothing got built. instead, just going to wrap use of `rustup` to check if running in ADO. Can't run it because it won't auth and MSAzure doesn't allow public feeds, but the rust installer task already set it up as needed anyways. ---- #### AI description (iteration 1) #### PR Classification Build script update. #### PR Summary This PR modifies the build script to conditionally bypass rustup commands when the `$usingADO` flag is set, ensuring that rustup is only used in non-ADO environments. - `build.ps1`: Wraps the rustup default command in a condition checking `$usingADO`. - `build.ps1`: Adds a condition to the rustup target addition so it executes only when the architecture is not 'Current' and `$usingADO` is false. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
This was referenced Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes