Skip to content

Fix build script to use CratesIO #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix build script to use CratesIO #1072

wants to merge 1 commit into from

Conversation

Gijsreyn
Copy link
Contributor

PR Summary

This pull request updates the usage of the UseCratesIO switch parameter vs config.toml. Also adds the changes from #1063

PR Context

Partially addresses #1036

SteveL-MSFT
SteveL-MSFT approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT
Copy link
Member

@Gijsreyn appreciate you taking the time to submit this, but I needed to make the same changes in #1076 to make it work so no longer need this PR

@Gijsreyn Gijsreyn deleted the fix-build-cratesio branch August 23, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gijsreyn @SteveL-MSFT