Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing flavor text entries for Pokemon: Legends Arceus and Pokemon Scarlet/Violet #1223

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

aserra54
Copy link
Contributor

This is a follow-up to #1221. This adds flavor texts from Pokemon: Legends Arceus and Pokemon Scarlet and Violet to all moves.

The data is all sourced from Bulbapedia, with manual spot-checking to ensure the integrity of the entries. I've rebuilt and spot-checked the API locally as well to make sure the entries are being rendered correctly.

Some relevant notes:

  • For some moves in Pokemon Scarlet/Violet, the flavor text was adjusted over time with patches (e.g. Dire Claw). In these cases, the latest, most up-to-date flavor text was used.
    • More explicitly, the old flavor text is not recorded anywhere in the API.
  • For Pokemon Scarlet/Violet, all flavor text is annotated with game ID 25; more specifically, new moves introduced in the DLCs were marked as being for Scarlet and Violet (e.g. "Ivy Cudgel").
    • I can change this, but this is consistent with how similar moves are treated in Sword & Shield, e.g. Surging Strikes (where its flavor text is denoted as being from sword-shield).

There was a discussion about whether it would be simple to add in the line breaks to the entries, but it turned out to be non-trivial on my end. My own personal setup is not conducive to doing this easily, and I don't have the time to do it personally. As such, I decided to put up all the raw data, and the maintainers can decide how to proceed.

Some notes:

  • If you'd like, we can merge this PR and I can open an issue to request for someone to add the line breaks. This way it would gain visibility and maybe someone with more free time than me could help out.
  • I noticed the endpoint for the move "Vise Grip" has a typo (https://pokeapi.co/api/v2/move/vise-grip yields a 404, but https://pokeapi.co/api/v2/move/vise-grip works). I can open an issue for that (and maybe fix it if I have the time), but at the same time, it's an existing/deployed endpoint; I'm not sure we'd want to rename it.

@aserra54 aserra54 changed the title Added missing flavor text entries for PLA and Pokemon Scarlet/Violet Added missing flavor text entries for Pokemon: Legends Arceus and Pokemon Scarlet/Violet Mar 14, 2025
@Naramsim
Copy link
Member

Hi! Thanks again for your dedication :) We can go without the line breaks. As for vise grip, both links return 404. We have it under vice-grip: https://pokeapi.co/api/v2/move/vice-grip/ we might need to change its name.

@Naramsim Naramsim merged commit d703354 into PokeAPI:master Mar 14, 2025
8 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@aserra54 aserra54 deleted the feat/move-flavor-text-pla-sv branch March 14, 2025 22:06
pokeapi-machine-user added a commit to PokeAPI/api-data that referenced this pull request Mar 14, 2025
@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants