Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing flavor text entries #1221

Closed

Conversation

aserra54
Copy link
Contributor

@aserra54 aserra54 commented Mar 9, 2025

Adds some missing flavor text entries for moves in Pokemon: Legends Arceus and Pokemon Scarlet/Violet. The data was sourced from Bulbapedia.

I'm submitting a small subset of changes to see if they line up with what you expect before making any larger scale changes. Notably, I'm not 100% sure if you want to preserve the line breaks from the original game, or if putting the plain text with no breaks is okay.

The generation and sorting of the file is done automatically via a one-off Python script to ensure the contents are placed in the correct locations. I can share the script if need be.

To help with some context:

Move ID 33: Tackle
Move ID 47: Sing
Move ID 421: Shadow Claw
Move ID 827: Dire Claw
Move ID 828: Psyshield Bash

Version ID 24: Pokemon: Legends Arceus
Version ID 25: Pokemon Scarlet & Violet

Language ID 9: English

@aserra54 aserra54 force-pushed the feat/move-flavor-text-prelim branch from 3bb3ed0 to fa9a58f Compare March 9, 2025 21:17
@Naramsim
Copy link
Member

Hi! This is great! Thanks for the contribution! I'd say that if you have some time and it's feasible/easy to even add in the line-breaks, than that would be perfect. If not, we can go with no line-breaks.

@aserra54
Copy link
Contributor Author

Sure, give me some time to see if I can find a way to make the process as painless as possible on my end, and I will get back to you.

@aserra54
Copy link
Contributor Author

Closing in favor of #1223.

@aserra54 aserra54 closed this Mar 14, 2025
@aserra54 aserra54 deleted the feat/move-flavor-text-prelim branch March 14, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants