Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rolling release #287

Open
wants to merge 15 commits into
base: ros2
Choose a base branch
from
Open

Add support for rolling release #287

wants to merge 15 commits into from

Conversation

martiniil
Copy link
Contributor

@martiniil martiniil commented Nov 25, 2021

Description

These changes add support for the ROS 2 rolling release.


PR Checklist

Things to add, update or check by the maintainers before this PR can be merged.

  • Public api function documentation
  • Architecture documentation reflects actual code structure
  • Tutorials
  • Overview on ROS wiki
  • Package Readme (example pilz_robots)
  • Good commit messages (some tips)
  • CHANGELOG.rst updated
  • Copyright headers
  • Examples

Review Checklist

  • Soft- and hardware architecture (diagrams and description)
  • Test review (test plan and individual test cases)
  • Documentation describes purpose of file(s) and responsibilities
  • Code (coding rules, style guide)

Release planning (please answer)

  • When is the new feature released? Could be released to rolling on next opportunity
  • Which dependent packages do have to be released simultaneously?

Hardware tests

Unstrike the text below to enable automatic hardware tests if available. Otherwise use this as a request for the reviewer.

  • Perform hardware tests

@martiniil
Copy link
Contributor Author

martiniil commented Nov 25, 2021

Edit: This was fixed by @jschleicher with 64fd9fd

  /usr/bin/ld: libpsen_scan_v2_standalone.a(scanner_v2.cpp.o): undefined reference to symbol '_ZNK3fmt2v68internal10locale_ref3getISt6localeEET_v'
  /usr/bin/ld: /lib/x86_64-linux-gnu/libspdlog.so.1: error adding symbols: DSO missing from command line

to fix build problem - not really sure, if this is the correct way to link the node aginst libfmt
defaults are a good idea and this way the code does not break
foxy and rolling.
to avoid name clashes with foxy build
and ignore startup of robot_state_publisher errors
@jschleicher jschleicher changed the title WIP: Add support for rolling release Add support for rolling release Jan 19, 2022
@jschleicher jschleicher marked this pull request as ready for review January 19, 2022 14:00
Copy link
Contributor

@agutenkunst agutenkunst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@agutenkunst agutenkunst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also update the changelog

jschleicher added a commit that referenced this pull request Jan 20, 2022
backports build status and description of ros2 branch from PR #287
to main
@martiniil
Copy link
Contributor Author

Hm, merge?

@agutenkunst
Copy link
Contributor

Sure!

@martiniil martiniil mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants