Fix a batch dim issue in resize_with_pad_torch#876
Open
Haichao-Zhang wants to merge 1 commit intoPhysical-Intelligence:mainfrom
Open
Fix a batch dim issue in resize_with_pad_torch#876Haichao-Zhang wants to merge 1 commit intoPhysical-Intelligence:mainfrom
Haichao-Zhang wants to merge 1 commit intoPhysical-Intelligence:mainfrom
Conversation
Haichao-Zhang
requested review from
Michael-Equi and
jimmyt857
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way of removing the batch dim in
resize_with_pad_torchcould cause issue when the batch size is actually 1.This PR fixes this issue and preserves the tensor shape from input to output and only removes the batch dim when it was added earlier.