[Validation][RPC] ProUpReg and ProUpRev special tx types by random-zebra · Pull Request #2363 · PIVX-Project/PIVX

random-zebra · 2021-05-05T00:16:49Z

Built on top of:

[Validation][RPC] Provider-Update-Service special tx type #2349

This concludes the first DMN-milestone list #2267 (comment).

Here we introduce the last two payloads and transaction types, adding relative RPC commands, and updating the tests:

PROUPREG (provider-update-registrar) submitted by the owner (the payload must be signed with the owner key) to update the operator key and/or the voting key and/or the payout address.
PROUPREV (provider-update-revoke) submitted by the operator, to revoke the service, and put the mn in PoSe-banned state (e.g. in case of compromised keys). The masternode can be "revived" later, by sending a ProUpReg tx, which sets a new operator key, and then a ProUpServ tx (signed with the new operator key), which sets the new IP address for the masternode.

random-zebra · 2021-06-18T10:33:36Z

Rebased on master. Ready to go.

furszy

Reviewed till e5292cf08a86a295983adc33ac08781225a82913. Still moving but looking great

src/test/evo_deterministicmns_tests.cpp

furszy

Initial code review ACK fb3f567a2e563caa7d3f0c5f45dfa4df9af39195, only found nits. Really nice work, awesome test coverage👌👌.

src/evo/deterministicmns.cpp

src/test/evo_deterministicmns_tests.cpp

random-zebra · 2021-06-26T13:56:56Z

Thanks for the review @furszy. Nits addressed.

furszy

Code ACK 853d8e1 after nits.
will start running it and test it live now.

furszy

re-utACK after rebase 663517e. Last one in the 2267 work path 🍻 .

furszy · 2021-07-01T19:34:05Z

Small conflict, needs rebase :\

random-zebra · 2021-07-02T09:59:30Z

Rebased...

check: - valid payload - payload malleability - owner script payout change - duplicate operator key - duplicate owner key

Otherwise a block with two protx using the same key could be accepted and then cause an assertion failure in AddUniqueProperty.

check: - valid payload - payload malleability

As changing the payout address, could be used maliciously to game the old payment system.

MalleateProUpServTx shouldn't re-use the ip (port) of an active masternode. Select the port with a number > 1000

random-zebra · 2021-07-06T14:48:56Z

Rebased on master (once again), and serialization updated.

furszy

No changes after rebase, only serialization code update. ACK 27d9f4e.

Will need to be rebased on master once #2471 gets merged so GA can run over it again.

Fuzzbawls

Code ACK 3c76eaf1048b595f72f812d377ca3be00dc3edf0

furszy

have run all the tests locally one more time, ACK 27d9f4e. Merging..

d3843cd [Refactor] No need to get the publickey of the active masternode (random-zebra) 483f509 [Refactor] De-duplicate operator BLS key parsing in rpc (random-zebra) 855c094 [Build] Fix CMake builds with chiabls/relic includes (random-zebra) 77ec208 [Tests] Fix TierTwo functional tests with BLS operator key (random-zebra) dd46f72 [TierTwo] Migration of DMN operator key to BLS (random-zebra) 1dfdcc1 [RPC] Implement generateblskeypair() RPC command (random-zebra) 619c0f8 scripted-diff: Rename keyIDOperator to pubKeyOperator (random-zebra) b0a7fa5 [QA] Add tests for fbv messages signed with BLS keys (random-zebra) dd0fb01 [TierTwo] Add functions to sign/verify messages with BLS (random-zebra) Pull request description: This builds on top of: - [x] #2363 - [x] #2419 - [x] #2420 As per title, introduce BLS keys/signatures for messages signed by the masternode operator (which is a requirement for [DIP 6](https://github.com/dashpay/dips/blob/master/dip-0006.md), and subsequent upgrades). - a new RPC command `generateblskeypair` returns a new publickey/secretkey BLS keypair. - `CDeterministicMNState::keyIDOperator` is now a `CBLSLazyPublicKey` (instead of a `CKeyID`), and it's renamed `pubKeyOperator`. - `-mnoperatorprivatekey` flag takes a BLS secret key in hex format. - `CActiveMasternodeInfo` stores a `CBLSPublicKey`/`CBLSSecretKey` - the BLS signature byte vector is serialized for legacy messages (mnw, fbv) in the compatibility code. ACKs for top commit: furszy: great, ACK d3843cd Fuzzbawls: ACK d3843cd Tree-SHA512: 1caf49615283d10b356caa049b57091dc70805c0bf2c11645d560c81223ce0d9936a46096cc4871c5ec25164518ebdf259d0f23a8c5bca39f2e436cc9e954519

random-zebra added RPC Validation Tests Masternode Upstream Dash labels May 5, 2021

random-zebra added this to the 6.0.0 milestone May 5, 2021

random-zebra self-assigned this May 5, 2021

random-zebra mentioned this pull request May 5, 2021

[Doc] Introducing Deterministic Masternodes #2267

Merged

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from 82731f0 to c4b4dc3 Compare May 8, 2021 13:07

random-zebra force-pushed the 202103-dmn-proupreg-rev branch 2 times, most recently from 7cdfbff to e6d827a Compare May 25, 2021 12:29

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from e6d827a to 13a82fd Compare May 31, 2021 14:52

random-zebra mentioned this pull request Jun 1, 2021

[Validation][RPC] Provider-Update-Service special tx type #2349

Merged

1 task

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from fe111b3 to ebcd13b Compare June 2, 2021 12:05

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from ebcd13b to d19c4b8 Compare June 14, 2021 14:54

random-zebra mentioned this pull request Jun 14, 2021

[Refactor] MN operator key migration to BLS #2421

Merged

3 tasks

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from d19c4b8 to fb3f567 Compare June 18, 2021 10:32

furszy reviewed Jun 25, 2021

View reviewed changes

src/test/evo_deterministicmns_tests.cpp Outdated Show resolved Hide resolved

furszy reviewed Jun 26, 2021

View reviewed changes

src/evo/deterministicmns.cpp Outdated Show resolved Hide resolved

src/test/evo_deterministicmns_tests.cpp Outdated Show resolved Hide resolved

src/test/evo_deterministicmns_tests.cpp Outdated Show resolved Hide resolved

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from fb3f567 to 853d8e1 Compare June 26, 2021 13:54

furszy reviewed Jun 26, 2021

View reviewed changes

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from 853d8e1 to 663517e Compare June 26, 2021 15:00

random-zebra requested a review from Fuzzbawls June 29, 2021 09:03

furszy previously approved these changes Jun 30, 2021

View reviewed changes

random-zebra dismissed furszy’s stale review via e60ada9 July 2, 2021 09:59

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from 663517e to e60ada9 Compare July 2, 2021 09:59

random-zebra force-pushed the 202103-dmn-proupreg-rev branch 2 times, most recently from 018a474 to 959f595 Compare July 6, 2021 13:55

random-zebra added 20 commits July 6, 2021 16:01

[Core] Introduce ProUpReg payload and transaction type

1f9e61c

[Tests] Add Get/Set payload unit-test for ProUpReg txes

ceeaf31

[TierTwo] Connect ProUpReg payload management in dmn manager

060729a

[Tests] Add provider-update-registrar to dip3_protx unit-test

553cd56

check: - valid payload - payload malleability - owner script payout change - duplicate operator key - duplicate owner key

[BUG] Check for duplicate operator key when processing ProUpReg txes

864c0f5

Otherwise a block with two protx using the same key could be accepted and then cause an assertion failure in AddUniqueProperty.

[Mempool] Conflict handling for ProUpReg txes

cb4ce9e

[RPC] Implement "protx_update_registrar" call

48e8862

[Tests] Functional testing for ProUpReg txes

1f01a5f

[Core] Introduce ProUpRev payload and transaction type

055f5d3

[Tests] Add Get/Set payload unit-test for ProUpRev txes

9699143

[TierTwo] Connect ProUpRev payload management in dmn manager

a4a0afb

[Tests] Add provider-update-revoke to dip3_protx unit-test

a822a03

check: - valid payload - payload malleability

[Mempool] Conflict handling for ProUpRev txes

86fd9db

[RPC] Implement "protx_revoke" call

2c16960

[Tests] Functional testing for ProUpRev txes

b02d147

[RPC][Trivial] Add missing RPC help examples

336e18c

[Consensus] Don't Allow ProUpReg txes while in transition to DMN

e2081a7

As changing the payout address, could be used maliciously to game the old payment system.

[Tests] Fix random failure and add MN revival test in deterministicmns

9e42dfb

[Trivial][Cleanup] Remove unused vZC_DENOMS from the test framework

2552e53

[QA] exercise generic calls to CheckSpecialTx and fix random bug

27d9f4e

MalleateProUpServTx shouldn't re-use the ip (port) of an active masternode. Select the port with a number > 1000

random-zebra force-pushed the 202103-dmn-proupreg-rev branch from 959f595 to 27d9f4e Compare July 6, 2021 14:01

random-zebra mentioned this pull request Jul 6, 2021

[Test] Fix evo_deterministicmns_tests fail for create a dup service addr #2472

Closed

furszy reviewed Jul 6, 2021

View reviewed changes

Fuzzbawls approved these changes Jul 7, 2021

View reviewed changes

furszy approved these changes Jul 7, 2021

View reviewed changes

furszy merged commit 8a683aa into PIVX-Project:master Jul 7, 2021

Conversation

random-zebra commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

random-zebra commented Jun 18, 2021

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

random-zebra commented Jun 26, 2021

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

furszy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

furszy commented Jul 1, 2021

Uh oh!

random-zebra commented Jul 2, 2021

Uh oh!

random-zebra commented Jul 6, 2021

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Fuzzbawls left a comment

Choose a reason for hiding this comment

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

random-zebra commented May 5, 2021 •

edited

Loading

furszy left a comment •

edited

Loading