Skip to content

[Test] Fix evo_deterministicmns_tests fail for create a dup service addr#2472

Closed
furszy wants to merge 1 commit intoPIVX-Project:masterfrom
furszy:2021_fix_dup_addr_test
Closed

[Test] Fix evo_deterministicmns_tests fail for create a dup service addr#2472
furszy wants to merge 1 commit intoPIVX-Project:masterfrom
furszy:2021_fix_dup_addr_test

Conversation

@furszy
Copy link

@furszy furszy commented Jul 6, 2021

Preventing the MalleateProUpServTx function for creating an already used addr by other DMN, triggering a different error instead of the expected bad-protx-sig.

Saw it failing once in GA, not very common for obvious reasons but it could still happen:

  Entering test module "Pivx Test Suite"
  test/evo_deterministicmns_tests.cpp(225): Entering test suite "deterministicmns_tests"
  test/evo_deterministicmns_tests.cpp(227): Entering test case "dip3_protx"
  test/evo_deterministicmns_tests.cpp(466): error: in "deterministicmns_tests/dip3_protx": check dummyState.GetRejectReason() == "bad-protx-sig" has failed [bad-protx-dup-addr != bad-protx-sig]
  test/evo_deterministicmns_tests.cpp(227): Leaving test case "dip3_protx"; testing time: 5607127us

Footnote: The bad-protx-dup-addr error is verified in another test case.

@furszy furszy self-assigned this Jul 6, 2021
@random-zebra
Copy link

This is already fixed in #2363 (27d9f4e)

@furszy
Copy link
Author

furszy commented Jul 6, 2021

ok yeah, i remember it now, all good, closing.

@furszy furszy closed this Jul 6, 2021
@furszy furszy deleted the 2021_fix_dup_addr_test branch November 29, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants