Skip to content

Vanadium integration #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Vanadium integration #2436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9acbe1f
Bump to ODL Vanadium versions
PeterSuna Oct 24, 2025
25f5873
Add dependency managment for ietf-artifacts
PeterSuna Oct 24, 2025
b090594
Remove atomix-storage and sal-akka-segmented-journal
PeterSuna Oct 24, 2025
e5196a9
Remove InstanceIdentifier-using methods
PeterSuna Nov 19, 2025
cc471b9
Remove deprecated DataObjectModification methods
PeterSuna Nov 19, 2025
73964f8
Replace deprecated YangInstanceIdentifier methods
PeterSuna Nov 19, 2025
ed9385c
Fix reduced DOMService implementation
PeterSuna Nov 19, 2025
22c4b32
Add missing SingletonService
PeterSuna Oct 28, 2025
b470033
Switch to Duration for shardInitializationTimeout
PeterSuna Oct 28, 2025
f02bdde
Remove LocalSnapshotStore
PeterSuna Oct 29, 2025
1bc909e
Bump Pekko to 1.2.1
PeterSuna Oct 29, 2025
e7887ca
Bump Scala to 3.3.6
PeterSuna Oct 29, 2025
ba5730d
Align Pekko and support libs versions
PeterSuna Oct 29, 2025
b6418dc
Set HTTP_1_1 for basic restconf test
PeterSuna Oct 30, 2025
08695de
Fix netconf-node-topology revision to 2025-11-03
PeterSuna Nov 14, 2025
b0d8722
Add missing SSH config to CallHome
PeterSuna Nov 14, 2025
aa7fa7b
Fix matching unordered JSON in cluster test
PeterSuna Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/lighty-rnc-app/test-lighty-rnc-app-cluster.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ assertNodeConnected() {

assertPodsTopologyResponse() {
local previousResponse=""
local currentNormalizedResponse=""
for pod_controller_ip in $POD_CONTROLLER_IPS;
do
TOPOLOGY_RESPONSE=$(curl --request GET \
Expand All @@ -135,15 +136,19 @@ assertPodsTopologyResponse() {
echo "Empty response from pod ip: $pod_controller_ip"
test_results+=(1)
continue
elif [[ -z "$previousResponse" ]]
fi

# Sort json objects to allow matching unordered JSON reply
currentNormalizedResponse=$(echo "$TOPOLOGY_RESPONSE" | jq -S '.')
if [[ -z "$previousResponse" ]]
then
# First request
echo "first response $TOPOLOGY_RESPONSE"
previousResponse=$TOPOLOGY_RESPONSE
previousResponse=$currentNormalizedResponse
continue
elif [[ "$previousResponse" != "$TOPOLOGY_RESPONSE" ]]
elif [[ "$previousResponse" != "$currentNormalizedResponse" ]]
then
echo "Previous response doesn't match: [ $previousResponse ] with current response : [ $TOPOLOGY_RESPONSE ]"
echo "Previous response doesn't match: [ $previousResponse ] with current response :[ $currentNormalizedResponse ]"
test_results+=(1)
continue
fi
Expand Down
4 changes: 0 additions & 4 deletions ...p-aggregator/lighty-rcgnmi-app-helm/helm/lighty-rcgnmi-app-helm/templates/configmaps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,6 @@ data:

journal.leveldb.dir = "target/journal"
snapshot-store.local.dir = "target/snapshots"
# Use lz4 compression for LocalSnapshotStore snapshots
snapshot-store.local.use-lz4-compression = false
# Size of blocks for lz4 compression: 64KB, 256KB, 1MB or 4MB
snapshot-store.local.lz4-blocksize = 256KB

journal {
leveldb {
Expand Down
2 changes: 1 addition & 1 deletion ...cations/lighty-rnc-app-aggregator/lighty-rnc-app-docker/example-config/configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
{ "usedBy": "RESTCONF", "name": "sal-remote-augment", "revision": "2023-11-03", "nameSpace": "urn:sal:restconf:event:subscription"},
{ "usedBy": "RESTCONF/NETCONF", "name": "ietf-yang-library", "revision": "2019-01-04", "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-yang-library"},
{ "usedBy": "NETCONF", "name": "netconf-keystore", "revision": "2024-07-08", "nameSpace": "urn:opendaylight:netconf:keystore"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2024-09-11", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2025-11-03", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name":"ietf-netconf", "revision":"2011-06-01", "nameSpace":"urn:ietf:params:xml:ns:netconf:base:1.0"},
{ "usedBy": "AAA", "name": "aaa-cert-mdsal", "revision":"2016-03-21", "nameSpace":"urn:opendaylight:yang:aaa:cert:mdsal"},
{ "usedBy": "AAA", "name": "aaa", "revision": "2016-12-14", "nameSpace": "urn:opendaylight:params:xml:ns:yang:aaa"},
Expand Down
6 changes: 1 addition & 5 deletions ...rnc-app-aggregator/lighty-rnc-app-helm/helm/lighty-rnc-app-helm/templates/configmaps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ data:
{ "usedBy": "RESTCONF", "name": "ietf-restconf", "revision": "2017-01-26", "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-restconf"},
{ "usedBy": "RESTCONF/NETCONF", "name": "ietf-yang-library", "revision": "2019-01-04", "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-yang-library"},
{ "usedBy": "NETCONF", "name": "netconf-keystore", "revision": "2024-07-08", "nameSpace": "urn:opendaylight:netconf:keystore"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2024-09-11", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2025-11-03", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name":"ietf-netconf", "revision":"2011-06-01", "nameSpace":"urn:ietf:params:xml:ns:netconf:base:1.0"},
{ "usedBy": "AAA", "name": "aaa-cert-mdsal", "revision":"2016-03-21", "nameSpace":"urn:opendaylight:yang:aaa:cert:mdsal"},
{ "usedBy": "AAA", "name": "aaa", "revision": "2016-12-14", "nameSpace": "urn:opendaylight:params:xml:ns:yang:aaa"},
Expand Down Expand Up @@ -184,10 +184,6 @@ data:

journal.leveldb.dir = "target/journal"
snapshot-store.local.dir = "target/snapshots"
# Use lz4 compression for LocalSnapshotStore snapshots
snapshot-store.local.use-lz4-compression = false
# Size of blocks for lz4 compression: 64KB, 256KB, 1MB or 4MB
snapshot-store.local.lz4-blocksize = 256KB

journal {
leveldb {
Expand Down
2 changes: 1 addition & 1 deletion ...y-rnc-app-aggregator/lighty-rnc-app/src/main/assembly/resources/sampleCallhomeConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
{ "usedBy":"RESTCONF/NETCONF","name":"ietf-yang-library","revision":"2019-01-04","nameSpace":"urn:ietf:params:xml:ns:yang:ietf-yang-library"},
{ "usedBy":"NETCONF","name":"ietf-netconf-monitoring","revision":"2010-10-04","nameSpace":"urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring"},
{ "usedBy":"NETCONF","name":"netconf-keystore","revision":"2024-07-08","nameSpace":"urn:opendaylight:netconf:keystore"},
{ "usedBy":"NETCONF","name":"netconf-node-topology","revision":"2024-09-11","nameSpace":"urn:opendaylight:netconf-node-topology"},
{ "usedBy":"NETCONF","name":"netconf-node-topology","revision":"2025-11-03","nameSpace":"urn:opendaylight:netconf-node-topology"},
{ "usedBy":"NETCONF","name":"netconf-node-optional","revision":"2024-06-11","nameSpace":"urn:opendaylight:netconf-node-optional"},
{ "usedBy":"NETCONF","name":"ietf-netconf","revision":"2011-06-01","nameSpace":"urn:ietf:params:xml:ns:netconf:base:1.0"},
{ "usedBy":"NETCONF","name":"odl-netconf-callhome-server","revision":"2024-01-29","nameSpace":"urn:opendaylight:params:xml:ns:yang:netconf-callhome-server"}
Expand Down
2 changes: 1 addition & 1 deletion ...y-applications/lighty-rnc-app-aggregator/lighty-rnc-module/src/test/resources/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
{ "usedBy": "RESTCONF", "name": "ietf-restconf-monitoring", "revision": "2017-01-26", "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-restconf-monitoring"},
{ "usedBy": "RESTCONF/NETCONF", "name": "ietf-yang-library", "revision": "2019-01-04", "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-yang-library"},
{ "usedBy": "NETCONF", "name": "netconf-keystore", "revision": "2024-07-08", "nameSpace": "urn:opendaylight:netconf:keystore"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2024-09-11", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2025-11-03", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name":"ietf-netconf", "revision":"2011-06-01", "nameSpace":"urn:ietf:params:xml:ns:netconf:base:1.0"},
{ "usedBy": "AAA", "name": "aaa", "revision": "2016-12-14", "nameSpace": "urn:opendaylight:params:xml:ns:yang:aaa"},
{ "usedBy": "AAA", "name": "aaa-cert-mdsal", "revision":"2016-03-21", "nameSpace":"urn:opendaylight:yang:aaa:cert:mdsal"},
Expand Down
2 changes: 1 addition & 1 deletion ...lications/lighty-rnc-app-aggregator/lighty-rnc-module/src/test/resources/http2Config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
{ "usedBy": "RESTCONF", "name": "sal-remote-augment", "revision": "2023-11-03", "nameSpace": "urn:sal:restconf:event:subscription"},
{ "usedBy": "RESTCONF/NETCONF", "name": "ietf-yang-library", "revision": "2019-01-04", "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-yang-library"},
{ "usedBy": "NETCONF", "name": "netconf-keystore", "revision": "2024-07-08", "nameSpace": "urn:opendaylight:netconf:keystore"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2024-09-11", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2025-11-03", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name":"ietf-netconf", "revision":"2011-06-01", "nameSpace":"urn:ietf:params:xml:ns:netconf:base:1.0"},
{ "usedBy": "AAA", "name": "aaa-cert-mdsal", "revision":"2016-03-21", "nameSpace":"urn:opendaylight:yang:aaa:cert:mdsal"},
{ "usedBy": "AAA", "name": "aaa", "revision": "2016-12-14", "nameSpace": "urn:opendaylight:params:xml:ns:yang:aaa"},
Expand Down
2 changes: 1 addition & 1 deletion ...lications/lighty-rnc-app-aggregator/lighty-rnc-module/src/test/resources/httpsConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
{ "usedBy": "RESTCONF", "name": "sal-remote-augment", "revision": "2023-11-03", "nameSpace": "urn:sal:restconf:event:subscription"},
{ "usedBy": "RESTCONF/NETCONF", "name": "ietf-yang-library", "revision": "2019-01-04", "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-yang-library"},
{ "usedBy": "NETCONF", "name": "netconf-keystore", "revision": "2024-07-08", "nameSpace": "urn:opendaylight:netconf:keystore"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2024-09-11", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name": "netconf-node-topology", "revision": "2025-11-03", "nameSpace": "urn:opendaylight:netconf-node-topology"},
{ "usedBy": "NETCONF", "name":"ietf-netconf", "revision":"2011-06-01", "nameSpace":"urn:ietf:params:xml:ns:netconf:base:1.0"},
{ "usedBy": "AAA", "name": "aaa-cert-mdsal", "revision":"2016-03-21", "nameSpace":"urn:opendaylight:yang:aaa:cert:mdsal"},
{ "usedBy": "AAA", "name": "aaa", "revision": "2016-12-14", "nameSpace": "urn:opendaylight:params:xml:ns:yang:aaa"},
Expand Down
2 changes: 1 addition & 1 deletion ...ations/lighty-rnc-app-aggregator/lighty-rnc-module/src/test/resources/openapi_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
{ "nameSpace": "urn:opendaylight:params:xml:ns:yang:controller:inmemory-datastore-provider", "name": "opendaylight-inmemory-datastore-provider", "revision": "2014-06-17" },
{ "nameSpace": "urn:ietf:params:xml:ns:yang:iana-afn-safi", "name": "iana-afn-safi", "revision": "2013-07-04" },
{ "nameSpace": "urn:opendaylight:params:xml:ns:yang:controller:md:sal:binding:impl", "name": "opendaylight-sal-binding-broker-impl", "revision": "2013-10-28" },
{ "nameSpace": "urn:opendaylight:netconf-node-topology", "name": "netconf-node-topology", "revision": "2024-09-11" },
{ "nameSpace": "urn:opendaylight:netconf-node-topology", "name": "netconf-node-topology", "revision": "2025-11-03" },
{ "nameSpace": "urn:ietf:params:xml:ns:yang:ietf-restconf", "name": "ietf-restconf", "revision": "2017-01-26" },
{ "nameSpace": "urn:ietf:params:xml:ns:netmod:notification", "name": "nc-notifications", "revision": "2008-07-14" },
{ "nameSpace": "urn:opendaylight:l2:types", "name": "opendaylight-l2-types", "revision": "2013-08-27" },
Expand Down
99 changes: 60 additions & 39 deletions lighty-core/dependency-versions/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<dependency>
<groupId>org.opendaylight.odlparent</groupId>
<artifactId>odlparent</artifactId>
<version>14.1.3</version>
<version>14.1.6</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -42,49 +42,56 @@
<dependency>
<groupId>org.opendaylight.aaa</groupId>
<artifactId>aaa-artifacts</artifactId>
<version>0.21.2</version>
<version>0.22.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.opendaylight.controller</groupId>
<artifactId>controller-artifacts</artifactId>
<version>11.0.2</version>
<version>12.0.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.opendaylight.infrautils</groupId>
<artifactId>infrautils-artifacts</artifactId>
<version>7.1.7</version>
<version>7.1.9</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.opendaylight.mdsal</groupId>
<artifactId>mdsal-artifacts</artifactId>
<version>14.0.18</version>
<version>15.0.2</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.opendaylight.netconf</groupId>
<artifactId>netconf-artifacts</artifactId>
<version>9.0.1</version>
<version>10.0.2</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.opendaylight.yangtools</groupId>
<artifactId>yangtools-artifacts</artifactId>
<version>14.0.17</version>
<version>14.0.20</version>
<type>pom</type>
<scope>import</scope>
</dependency>
<dependency>
<groupId>org.opendaylight.bgpcep</groupId>
<artifactId>bgpcep-artifacts</artifactId>
<version>0.23.1</version>
<version>0.24.0-SNAPSHOT</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Comment on lines +87 to +90
Copy link

@gemini-code-assist gemini-code-assist bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version for bgpcep-artifacts is using a -SNAPSHOT version. While this might be acceptable for development, it's generally not recommended for stable releases. Consider using a released version if available.

If a released version is not available, confirm that the snapshot version is intended for this integration.

<dependency>
<groupId>org.opendaylight.ietf</groupId>
<artifactId>ietf-artifacts</artifactId>
<version>1.0.2</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -103,7 +110,7 @@
<dependency>
<groupId>com.typesafe</groupId>
<artifactId>config</artifactId>
<version>1.4.3</version>
<version>1.4.5</version>
</dependency>
<dependency>
<groupId>org.testng</groupId>
Expand Down Expand Up @@ -164,78 +171,78 @@
<!--pekko management and bootstrap-->
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-remote_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-remote_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-slf4j_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-slf4j_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-cluster_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-cluster_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-discovery_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-discovery_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-protobuf_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-protobuf-v3_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-coordination_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-coordination_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-distributed-data_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-distributed-data_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-cluster-tools_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-cluster-tools_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-cluster-sharding_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-cluster-sharding_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-actor_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-actor_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-stream_2.13</artifactId>
<version>1.0.3</version>
<artifactId>pekko-stream_3</artifactId>
<version>1.2.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-management_2.13</artifactId>
<version>1.0.0</version>
<artifactId>pekko-management_3</artifactId>
<version>1.1.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-management-cluster-http_2.13</artifactId>
<version>1.0.0</version>
<artifactId>pekko-management-cluster-http_3</artifactId>
<version>1.1.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-management-cluster-bootstrap_2.13</artifactId>
<version>1.0.0</version>
<artifactId>pekko-management-cluster-bootstrap_3</artifactId>
<version>1.1.1</version>
</dependency>
<dependency>
<groupId>org.apache.pekko</groupId>
<artifactId>pekko-discovery-kubernetes-api_2.13</artifactId>
<version>1.0.0</version>
<artifactId>pekko-discovery-kubernetes-api_3</artifactId>
<version>1.1.1</version>
</dependency>
<dependency>
<groupId>org.json</groupId>
Expand Down Expand Up @@ -301,4 +308,18 @@
<organizationUrl>https://www.pantheon.tech</organizationUrl>
</developer>
</developers>
<repositories>
<!-- TODO: Remove when will be available bgpcep-artifacts release -->
<repository>
<id>opendaylight-snapshot</id>
<name>opendaylight-snapshot</name>
<url>https://nexus.opendaylight.org/content/repositories/opendaylight.snapshot/</url>
<releases>
<enabled>false</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</repository>
</repositories>
</project>
4 changes: 2 additions & 2 deletions lighty-core/lighty-binding-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@
<plugin>
<groupId>org.opendaylight.yangtools</groupId>
<artifactId>yang-maven-plugin</artifactId>
<version>14.0.17</version>
<version>14.0.20</version>
<dependencies>
<dependency>
<groupId>org.opendaylight.yangtools</groupId>
<artifactId>binding-codegen</artifactId>
<version>14.0.17</version>
<version>14.0.20</version>
</dependency>
</dependencies>
<executions>
Expand Down
Loading
Loading