Skip to content

Conversation

@PeterSuna
Copy link
Contributor

@PeterSuna PeterSuna commented Oct 24, 2025

Bump to ODL Vanadium versions

Adopt:
  - odlparent-14.1.6
  - infrautils-7.1.9
  - yangtools-14.0.20
  - mdsal-15.0.2
  - controller-12.0.3
  - aaa-0.22.3
  - netconf-10.0.2
  - bgpcep-0.24.0-SNAPSHOT

JIRA: LIGHTY-391

@gemini-code-assist
Copy link

Summary of Changes

Hello @PeterSuna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant integration by upgrading the project's dependencies to align with the OpenDaylight Vanadium release. It involves bumping numerous component versions and standardizing the groupId for IETF model artifacts. Additionally, the PR streamlines the Akka persistence mechanism by removing the segmented file journal, which likely indicates a shift to a different or simplified persistence strategy.

Highlights

  • Dependency Version Updates: Multiple core OpenDaylight component dependencies have been updated to their latest Vanadium release versions, including odlparent, aaa-artifacts, controller-artifacts, infrautils-artifacts, mdsal-artifacts, netconf-artifacts, yangtools-artifacts, and bgpcep-artifacts. A new ietf-artifacts dependency has also been introduced.
  • IETF Model GroupId Refactoring: The groupId for several IETF model artifacts (e.g., iana-if-type, rfc6991-ietf-inet-types, rfc8343, rfc6241, rfc6022, rfc8526) has been unified from org.opendaylight.mdsal.binding.model.iana or org.opendaylight.mdsal.binding.model.ietf to the more generic org.opendaylight.ietf.model across various pom.xml files.
  • Akka Persistence Configuration Removal: The Akka segmented file journal configuration and its corresponding dependency (sal-akka-segmented-journal) have been removed from the project, simplifying the persistence setup.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the versions of several OpenDaylight dependencies in the dependency-versions/pom.xml file and replaces some org.opendaylight.mdsal.binding.model.iana dependencies with org.opendaylight.ietf.model in various pom.xml files. Additionally, it removes the pekko-segmented-journal dependencies and persistence journal configurations. The dependency version updates seem reasonable, but the removal of the persistence journal configurations warrants closer inspection to ensure no data loss or functional regressions occur.

Comment on lines +87 to +90
<version>0.24.0-SNAPSHOT</version>
<type>pom</type>
<scope>import</scope>
</dependency>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The version for bgpcep-artifacts is using a -SNAPSHOT version. While this might be acceptable for development, it's generally not recommended for stable releases. Consider using a released version if available.

If a released version is not available, confirm that the snapshot version is intended for this integration.

@PeterSuna PeterSuna force-pushed the vanadium branch 5 times, most recently from e7d0f97 to c6a986c Compare October 29, 2025 17:10
@PeterSuna PeterSuna force-pushed the vanadium branch 7 times, most recently from d8d041f to 6ca89d2 Compare November 19, 2025 22:15
Adopt:
- odlparent-14.1.6
- infrautils-7.1.9
- yangtools-14.0.20
- mdsal-15.0.2
- controller-12.0.3
- aaa-0.22.3
- netconf-10.0.2
- bgpcep-0.24.0-SNAPSHOT

JIRA: LIGHTY-391
Signed-off-by: Peter Suna <[email protected]>
Models from mdsal migrated to ietf-artifacts repository.
Add dependency to ietf-artifacts and fix dependencies to related models.
See MDSAL-886.

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
sal-akka-segmented-journal and atomix-storage became obsolete.
Remove both artifacts and any configuration references to them.
See CONTROLLER-2152.

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
InstanceIdentifier is replaced with DataObjectIdentifier and all
methods using InstanceIdentifier are being deprecated.
Switch to DataObjectIdentifier usage.
See MDSAL-817 and MDSAL-887

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
DataObjectModification was remodeled intorducing new way how to
handle onDataTreeChanged.
See MDSAL-889 and NETCONF-1530

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
Modernize usage of YangInstanceIdentifier, replacing deprecated
methods.
See:
Ie6a431deaca0a80b8ce1d16dad5a1b919c94f722

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
DOMRpcRouter and other does not provide prepared DOMService.
Create them and povide those implementation in LightyControllerImpl.
See MDSAL-884.

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
Add misising ClusterSingletonServiceProvider into
MdsalRestconfStreamRegistry.
See NETCONF-1484

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
Use java.time.Duration instead, converting to FiniteDuration where
needed.
See CONTROLLER-2180

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
We are not using Pekko Persistence, this removes our custom storage
plugin along with the configuration tweaks.
See CONTROLLER-2151

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
Package the Scala 3 version of Pekko.
See CONTROLLER-2167.

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
Set new revsion for netconf-node-topology 2025-11-03.
See NETCONF-1502.

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
Update Callhome configuration with SSH config.
See NETCONF-1502.

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
New NETCONF release added SSH topology-types container to topology.
The topology container is unordered ("node" list and
"topology-types" container order varies).

Fix this by sorting JSON before comparing replies for
consistent test results.

JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant