-
Notifications
You must be signed in to change notification settings - Fork 81
Vanadium integration #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vanadium integration #2436
Conversation
Summary of ChangesHello @PeterSuna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant integration by upgrading the project's dependencies to align with the OpenDaylight Vanadium release. It involves bumping numerous component versions and standardizing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the versions of several OpenDaylight dependencies in the dependency-versions/pom.xml file and replaces some org.opendaylight.mdsal.binding.model.iana dependencies with org.opendaylight.ietf.model in various pom.xml files. Additionally, it removes the pekko-segmented-journal dependencies and persistence journal configurations. The dependency version updates seem reasonable, but the removal of the persistence journal configurations warrants closer inspection to ensure no data loss or functional regressions occur.
| <version>0.24.0-SNAPSHOT</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version for bgpcep-artifacts is using a -SNAPSHOT version. While this might be acceptable for development, it's generally not recommended for stable releases. Consider using a released version if available.
If a released version is not available, confirm that the snapshot version is intended for this integration.
e7d0f97 to
c6a986c
Compare
d8d041f to
6ca89d2
Compare
Adopt: - odlparent-14.1.6 - infrautils-7.1.9 - yangtools-14.0.20 - mdsal-15.0.2 - controller-12.0.3 - aaa-0.22.3 - netconf-10.0.2 - bgpcep-0.24.0-SNAPSHOT JIRA: LIGHTY-391 Signed-off-by: Peter Suna <[email protected]>
Models from mdsal migrated to ietf-artifacts repository. Add dependency to ietf-artifacts and fix dependencies to related models. See MDSAL-886. JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
sal-akka-segmented-journal and atomix-storage became obsolete. Remove both artifacts and any configuration references to them. See CONTROLLER-2152. JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
InstanceIdentifier is replaced with DataObjectIdentifier and all methods using InstanceIdentifier are being deprecated. Switch to DataObjectIdentifier usage. See MDSAL-817 and MDSAL-887 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
DataObjectModification was remodeled intorducing new way how to handle onDataTreeChanged. See MDSAL-889 and NETCONF-1530 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
Modernize usage of YangInstanceIdentifier, replacing deprecated methods. See: Ie6a431deaca0a80b8ce1d16dad5a1b919c94f722 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
DOMRpcRouter and other does not provide prepared DOMService. Create them and povide those implementation in LightyControllerImpl. See MDSAL-884. JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
Add misising ClusterSingletonServiceProvider into MdsalRestconfStreamRegistry. See NETCONF-1484 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
Use java.time.Duration instead, converting to FiniteDuration where needed. See CONTROLLER-2180 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
We are not using Pekko Persistence, this removes our custom storage plugin along with the configuration tweaks. See CONTROLLER-2151 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
Pekko: https://pekko.apache.org/docs/pekko/current/release-notes/releases-1.1.html#1-1-0 https://pekko.apache.org/docs/pekko/current/release-notes/releases-1.1.html#1-1-1 https://pekko.apache.org/docs/pekko/current/release-notes/releases-1.1.html#1-1-2 https://pekko.apache.org/docs/pekko/current/release-notes/releases-1.1.html#1-1-3 https://pekko.apache.org/docs/pekko/current/release-notes/releases-1.1.html#1-1-4 https://pekko.apache.org/docs/pekko/current/release-notes/releases-1.2.html#1-2-0 https://pekko.apache.org/docs/pekko/current/release-notes/releases-1.2.html#1-2-1 See: CONTROLLER-2130 CONTROLLER-2175 JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
Package the Scala 3 version of Pekko. See CONTROLLER-2167. JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
https://pekko.apache.org/docs/pekko-management/1.1.1/pekko-management.html https://pekko.apache.org/docs/pekko-management/1.1.1/cluster-http-management.html https://pekko.apache.org/docs/pekko-management/1.1.1/bootstrap/index.html https://pekko.apache.org/docs/pekko-management/1.1.1/discovery/kubernetes.html JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
default is HTTP_2 https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html#version() JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
Set new revsion for netconf-node-topology 2025-11-03. See NETCONF-1502. JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
Update Callhome configuration with SSH config. See NETCONF-1502. JIRA: LIGHTY-394 Signed-off-by: Peter Suna <[email protected]>
New NETCONF release added SSH topology-types container to topology.
The topology container is unordered ("node" list and
"topology-types" container order varies).
Fix this by sorting JSON before comparing replies for
consistent test results.
JIRA: LIGHTY-394
Signed-off-by: Peter Suna <[email protected]>
JIRA: LIGHTY-391