Skip to content

Fix incorrect cast from BF16 to FP32 in SBGEMM #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 1 commit into from
Mar 27, 2026
+15 −9
Merged

Fix incorrect cast from BF16 to FP32 in SBGEMM #5712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions kernel/generic/gemmkernel_2x2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@

#include "conversion_macros.h"

#ifdef BGEMM
#define C_TO_F32 TO_F32
#else
#define C_TO_F32
#endif

int CNAME(BLASLONG bm,BLASLONG bn,BLASLONG bk,FLOAT alpha,IFLOAT* ba,IFLOAT* bb,FLOAT* C,BLASLONG ldc
#ifdef TRMMKERNEL
,BLASLONG offset
Expand Down Expand Up @@ -108,13 +114,13 @@ int CNAME(BLASLONG bm,BLASLONG bn,BLASLONG bk,FLOAT alpha,IFLOAT* ba,IFLOAT* bb,
ptrbb = ptrbb+2;
}
res0 = res0*ALPHA;
C0[0] = TO_OUTPUT(TO_F32(C0[0])+res0);
C0[0] = TO_OUTPUT(C_TO_F32(C0[0])+res0);
res1 = res1*ALPHA;
C0[1] = TO_OUTPUT(TO_F32(C0[1])+res1);
C0[1] = TO_OUTPUT(C_TO_F32(C0[1])+res1);
res2 = res2*ALPHA;
C1[0] = TO_OUTPUT(TO_F32(C1[0])+res2);
C1[0] = TO_OUTPUT(C_TO_F32(C1[0])+res2);
res3 = res3*ALPHA;
C1[1] = TO_OUTPUT(TO_F32(C1[1])+res3);
C1[1] = TO_OUTPUT(C_TO_F32(C1[1])+res3);
C0 = C0+2;
C1 = C1+2;
}
Expand All @@ -134,9 +140,9 @@ int CNAME(BLASLONG bm,BLASLONG bn,BLASLONG bk,FLOAT alpha,IFLOAT* ba,IFLOAT* bb,
ptrbb = ptrbb+2;
}
res0 = res0*ALPHA;
C0[0] = TO_OUTPUT(TO_F32(C0[0])+res0);
C0[0] = TO_OUTPUT(C_TO_F32(C0[0])+res0);
res1 = res1*ALPHA;
C1[0] = TO_OUTPUT(TO_F32(C1[0])+res1);
C1[0] = TO_OUTPUT(C_TO_F32(C1[0])+res1);
C0 = C0+1;
C1 = C1+1;
}
Expand Down Expand Up @@ -165,9 +171,9 @@ int CNAME(BLASLONG bm,BLASLONG bn,BLASLONG bk,FLOAT alpha,IFLOAT* ba,IFLOAT* bb,
ptrbb = ptrbb+1;
}
res0 = res0*ALPHA;
C0[0] = TO_OUTPUT(TO_F32(C0[0])+res0);
C0[0] = TO_OUTPUT(C_TO_F32(C0[0])+res0);
res1 = res1*ALPHA;
C0[1] = TO_OUTPUT(TO_F32(C0[1])+res1);
C0[1] = TO_OUTPUT(C_TO_F32(C0[1])+res1);
C0 = C0+2;
}
for (i=0; i<(bm&1); i+=1)
Expand All @@ -183,7 +189,7 @@ int CNAME(BLASLONG bm,BLASLONG bn,BLASLONG bk,FLOAT alpha,IFLOAT* ba,IFLOAT* bb,
ptrbb = ptrbb+1;
}
res0 = res0*ALPHA;
C0[0] = TO_OUTPUT(TO_F32(C0[0])+res0);
C0[0] = TO_OUTPUT(C_TO_F32(C0[0])+res0);
C0 = C0+1;
}
k = (bk<<0);
Expand Down
Loading