Fix incorrect cast from BF16 to FP32 in SBGEMM#5712
Fix incorrect cast from BF16 to FP32 in SBGEMM#5712martin-frbg merged 1 commit intoOpenMathLib:developfrom
Conversation
This change fixes a regression in SBGEMM where C is assumed to be BF16, and so unconditionally casts the output to FP32 resulting in incorrect outputs when beta=1.
|
@martin-frbg is there a way we can get a patch release for OpenBLAS? |
|
Yes, I'll try to do 0.3.33 this weekend - though the spurious utest failure bothers me a lot less than the weird DDOT bug that my workaround for the weird Neoverse SDOT bug introduced. Coincidentally the Reference-LAPACK team is committing a flurry of fixes for their upcoming 3.13, so it looks like a good chance to import those as well. |
|
that'll be much appreciated! 🙏 |
|
I think this is what I've been pointing out for a while now. |
@martin-frbg gentle nudge on this. Do you think we've a release candidate for 0.3.33 or are we waiting for more patches / fixes? |
4 participants
This change fixes a regression in SBGEMM where C is assumed to be BF16, and so unconditionally attempts to cast elements of C from BF16 to FP32 resulting in incorrect outputs when beta=1.