[seantronsen]

Description

lint-codegen-fabrica fails on every caller, before it checks anything. It checks Fabrica out to fabrica/, inside the caller's work tree, so make generate-check sees an untracked fabrica/ and exits 2 ("Working tree must be clean"). Nobody noticed, because no repo called the reusable workflow until the testbed did (OpenCHAMI/github-actions-testbed#14).

• lint-codegen-fabrica: adds /fabrica/ to .git/info/exclude after the Fabrica checkout.

Reproduced with the CI layout (Fabrica checked out inside the caller): generate-check exits 2 without the fix and 0 with it, and still fails when generated code has drifted.

Stacked on #50.

Testbed: OpenCHAMI/github-actions-testbed#14.

Checklist

• My code follows the style guidelines of this project
• I have added/updated comments where needed
• I have added tests that prove my fix is effective or my feature works
• I have run make test (or equivalent) locally and all tests pass
• I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
• DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
• REUSE Compliance:
  • Each new/modified source file has SPDX copyright and license headers
  • Any non-commentable files include a <filename>.license sidecar
  • All referenced licenses are present in the LICENSES/ directory

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update
• Dependency update
• Build system/CI

---

• I agree to follow the Code of Conduct.

[synackd]

Want to see how this is tested in OpenCHAMI/github-actions-testbed#14 (comment).

[seantronsen]

Want to see how this is tested in OpenCHAMI/github-actions-testbed#14 (comment).

Done.

https://github.com/OpenCHAMI/github-actions-testbed/actions/runs/41531980722/job/125574228539

[seantronsen]

@synackd please review again when time is available.

[synackd]

Approving based on scoped changes. Makefile stuff needs to be worked out still but I think this is ready.

[synackd]

After the rebase, this PR's head is 5465b701d85559086f6a9f5d075f8b5ba81e682f. The testbed PR (OpenCHAMI/github-actions-testbed#14) still pins lint-codegen-fabrica to the old 861e95d552181a730e085f487769f1c66696d813 commit.

The workflow file is byte-for-byte identical at both SHAs, so the prior passing run and deliberate-drift test still cover this change. Please update the testbed pin to the current head and rerun the job before merging.