Repository navigation
feat!: testing for actions PR 51 - #14
seantronsen wants to merge 3 commits into
Conversation
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
bf51b36 to
5a999e1
Compare
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
95d46d8 to
5fef860
Compare
|
I see we test the happy path. Do we test that code drift causes this to fail anywhere? |
The recent commit 1af3ff2 will test this explicitly and be dropped after. |
1af3ff2 to
5fef860
Compare
|
CI is busted up because all the rebase shenanigans which changed all the sha pins. I'll update this whole sale later so each occurs at the correct position in the stack. |
synackd
left a comment
There was a problem hiding this comment.
Approving based on scoped changes. Makefile stuff needs to be worked out still but I think this is ready.
|
OpenCHAMI/github-actions#51 was rebased. Please update the The workflow file is identical at both commits, so the earlier passing generation check and deliberate-drift failure remain valid behavior tests. Updating the pin keeps this testbed tied to the current PR head. |
Description
Note
lint-makefile-commonfails until v4.0 is released (see #11).Testbed for OpenCHAMI/github-actions#51. Converts the testbed into a minimal Fabrica project, so it can test the Fabrica code generation checks: the
lint-codegen-fabricaworkflow (OpenCHAMI/github-actions#39) and thegenerate/generate-checktargets in Makefile.common (OpenCHAMI/github-actions#48).Widgetresource and file storage. The generated code is in its own commit, separate from the files written by hand.testbedbinary is now the Fabrica server (./cmd/server, withserveas the image's default command). It replacescmd/testbed. Release outputs and package contents are unchanged.lint.yml: addslint-codegen-fabricato thelintgate, pinned to the fix(workflows): step 9, keep the Fabrica checkout out of generate-check github-actions#51 head.go 1.26.10: Fabrica requires at least 1.26.6, which has a standard-library vulnerability reachable from our code (GO-2026-6617).Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change