Skip to content

Brijesh fix cannot create new team#1340

Open
brn8 wants to merge 2 commits intodevelopmentfrom
Brijesh_fix_cannot_create_newteam
Open

Brijesh fix cannot create new team#1340
brn8 wants to merge 2 commits intodevelopmentfrom
Brijesh_fix_cannot_create_newteam

Conversation

@brn8
Copy link

@brn8 brn8 commented Apr 16, 2025

Description

This PR resolves an issue where users were unable to create new teams. The changes ensure that the team creation functionality now works as intended.
WhatsApp Image 2025-03-25 at 21 19 42_c087e9c7

Related PRS (if any):

This backend PR is not related to any frontend PR.

Main changes explained:

  • Fixed the issue preventing users from creating new teams.
  • Verified the fix with successful team creation during testing.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to Other Links → Teams→ Create New Team
  6. verify that you can now create a new team and that the newly created team appears as expected.

Screenshots or videos of changes:

image

Note:

Include the information the reviewers need to know.

@brn8 brn8 added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 16, 2025
@AnthonyWeathers
Copy link
Contributor

Successfully tested, and can verify that this does fix the can not create new teams, but I've discovered that the code you added to preserve null or empty arrays, also shows the teams that were created but never shown. In the picture I attached, I created a team on the development branch which appeared then disappeared and I couldn't find it, but on using this fix, the team I made before appeared because the app hid teams that are empty. Which is why creating and assigning a user to a the new team through profile works, but not creating a team through the team management link. Good job on fixing it. I shall approve this.

image_2025-04-21_140940998

Copy link
Contributor

@AnthonyWeathers AnthonyWeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

Copy link
Contributor

@JuliaHa0902 JuliaHa0902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the pull request, install and build the application again. I tested adding team through Other Links > Teams > Create New Team using multiple roles. The function works as intended. I am also able to add members to the team. I approved.
Screenshot 2025-04-22 001225
Screenshot 2025-04-22 001258

Copy link

@guthaVamshi guthaVamshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the pull request, reinstalled dependencies, and rebuilt the application. Tested creating a new team via Other Links → Teams → Create New Team using multiple roles, and the functionality worked as expected. Also verified that members can be added to the team successfully. Approved the PR.
Screenshot 2025-04-24 at 10 13 29 AM

Copy link
Contributor

@gopikalakshmia gopikalakshmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes, checked out the branch, and created a new team. Everything is working as expected, including the validation message. Approving the PR.
image

I have a small suggestion: if you could add a minimum length requirement for the team name, that would be great.

Copy link

@pavanputti pavanputti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the fix by checking out the current branch, running npm install, and starting the app locally after clearing the site data and cache. I logged in as an admin user, navigated to "Other Links" > "Teams" > "Create New Team," and verified that I could successfully create a new team, with the newly created team appearing as expected.

Screenshot 2025-04-26 at 1 28 34 AM

Copy link

@npolasani npolasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the branch and ran npm install to install dependencies and successfully ran the backend locally. Logged in on the frontend as both Admin and Owner roles.
Navigated to Other Links → Teams → Create New Team.
Successfully created a new team and added members without issues. Reviewed the code and Approving the PR.

image

@one-community one-community added Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. and removed High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible labels May 18, 2025
Copy link

@harika-majji harika-majji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the frontend pr for detailed comments. The edit button is not working for updating team information.

Copy link

@BenithaSri BenithaSri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the steps and was successful in creating a new team.
Screenshot 2025-07-30 at 11 43 23 AM

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brijesh,

I have reviewed your PR locally and able to create new team.
Screenshot 2026-01-16 at 4 24 50 PM

@pavanputti pavanputti force-pushed the Brijesh_fix_cannot_create_newteam branch 2 times, most recently from be321ca to a4c01d1 Compare February 15, 2026 05:00
…ndContact

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.