fix/create-and-improve-create-new-team#3658
Conversation
…iltering logic. Removed CreateNewTeamPopup and updated state management for team data. Improved search functionality and UI elements in TeamTableSearchPanel and AddTeamsAutoComplete components.
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pavanputti
changed the title
rishiapk
added
the
High Priority - Please Review First
…sed parameter, streamlining the code for better readability and maintainability.
… placeholder text for search input to enhance clarity and accuracy of test cases.
Saicharan1505
left a comment
Saicharan1505
left a comment
There was a problem hiding this comment.
Tested the updated “Create New Team” workflow under Other Links > Team Management. Verified bug fix and UX improvements including autocomplete, duplicate name validation, and non-existent team creation flow. All test cases (basic creation, empty name, duplicate name, autocomplete, cancel creation) worked as expected. The new team appears in the list and supports further actions like adding members or editing. No issues found.
marcusyi1
left a comment
marcusyi1
left a comment
There was a problem hiding this comment.
Everything else in this branch works as expected. However there is an edge case where if you put a space in the team name it still registers as a new team. Could be good idea to add something to prevent this.
PR3658.mov
uhakruthi1
left a comment
uhakruthi1
left a comment
There was a problem hiding this comment.
Everything is working well locally. Tested the frontend thoroughly with backend PR #1340. Team creation flow, validation, and autocomplete features are all functioning as expected.Verified team appears correctly in the list after creation and can be edited or managed as intended. UX behavior matches the described workflow smoothly.
|
Tested all scenarios and everything is working as expected. 
|
saikrishnaraoyadagiri
left a comment
saikrishnaraoyadagiri
left a comment
There was a problem hiding this comment.
Hi, Reviewed this PR, all cases are working but when we get the error message showing team already exists it is staying in the popup even after clicking cancel team, create ream or confirm, until we refresh the browser. Attaching video for reference.
saikrishna.PR.3658+1340.mp4
harshavarma29
left a comment
harshavarma29
left a comment
There was a problem hiding this comment.
I have tested the latest changes locally using the admin account with the following scenarios listed below:
- Creating a new team.
- Empty team name.
- Autocomplete functionality.
They are working well. However, below two scenarios not working as expected.
-
Duplicate team name:
When creating a duplicate team name, a pop-up with a message 'A team with this name already exists' is not appearing in the UI, even though it is handled in the code.
Please refer to the attached video for this scenario.
existing-team-popup.mp4
-
Cancel team creation.
When clicking on 'Cancel team creation' for a non-existing team, the pop-up does not getting disappear.cancel-team-popup-not-closing.mp4
…uplicate team validation, improve search text handling, and update UI alerts for better user experience. Clear duplicate state on close and refine team creation logic.
pavanputti
dismissed stale reviews from uhakruthi1 and Saicharan1505
via
9bdd3c2
pavanputti
requested review from
Saicharan1505,
harshavarma29,
marcusyi1,
saikrishnaraoyadagiri and
uhakruthi1
harika-majji
left a comment
harika-majji
left a comment
There was a problem hiding this comment.
Tested the functionality as descripted in description.
Team List - edit button is not working. ( see last image for reference)
1. Basic Team Creation:
Team is created successfully, a success message appears, and the new team is listed under Team Management as an active team.
2. Empty Team Name:
Error message appears: "Please enter a team name."
3. Duplicate Team Name:
Warning message appears about the team already existing.
4. Autocomplete Functionality: works as expected.
5. Non-existent Team Creation Flow:
Warning message when a team doesn't exists "Oops, this team does not exist!" with two buttons: "Create Team" and "Cancel team creation."
6. Cancel Team Creation:
Cancel button works as expected.
After creating a team:
The new team appears in the teams list.
- Delete Button is working as expected.
- Add/ Delete Members for a team works as expected.
- The edit button is not working.
sankargalla
left a comment
sankargalla
left a comment
There was a problem hiding this comment.
I reviewed the PR, and all the following use cases work as expected: Basic Team Creation, Empty Team Name, Duplicate Team Name, Autocomplete Functionality, Non-existent Team Creation Flow, and Cancel Team Creation. After successfully creating a team, its details appear in the table with the Add Members, Edit, and Delete buttons. The Add Members and Delete actions function correctly.
Observation: Edit button is not working as expected.
…ddTeamPopup: Added state management for editing teams, including validation and UI updates for better user experience.
…e in ID check, update test assertions for team name display, and improve loading state handling in button interactions.
@marcusyi1 Thanks for pointing that out! I've addressed the edge case where spaces in the team name were creating new teams. The logic now trims whitespace and checks for duplicates accordingly. I've committed the changes—please take a look and let me know if anything else needs adjustment. |
@saikrishnaraoyadagiri Thanks for the feedback. I've made the necessary changes and committed the updated code. Let me know if anything else needs to be updated. |
@harshavarma29 Thanks for the feedback. I've made the necessary changes and committed the updated code. Let me know if anything else needs to be updated. |
@harika-majji Thanks for pointing it out. I've looked into the issue with the edit button and pushed a fix. Please review and let me know if it's working as expected now. |
@sankargalla Thanks for pointing it out. I've looked into the issue with the edit button and pushed a fix. Please review and let me know if it's working as expected now. |
…gic, improve error handling during team updates, and refine loading state management. Update tests for button interactions to ensure proper loading state behavior.
marcusyi1
left a comment
marcusyi1
left a comment
There was a problem hiding this comment.
This branch is not supported by Node 20 anymore.
|
- Added useParams import from react-router-dom - Extract activityid parameter from URL route - Added validation and error handling for missing activityId - Component now receives activityId from URL parameter - Prepared component for dynamic data fetching in next commit
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Pavan,
I tried reviewing your PR but most of the key successful messages have changed. Unable to see any duplicate message as well. There is no Cancel option as well.
pavanputti
force-pushed
the
fix/create-and-improve-create-new-team
branch
from
3f0448f to
9df5435
Compare
pavanputti
force-pushed
the
fix/create-and-improve-create-new-team
branch
from
9df5435 to
dd6c6f4
Compare
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Pavan,
I have re-reviewed your PR as there were few commits made. Thanks for fixing few issues however i was unable to verify the below:
- Autocomplete Functionality
- Non-existent Team Creation Flow
- Cancel Team Creation
Verified
Ensure empty or space-only input shows the pick-a-team message and avoid showing create-new options for blank text.
Keep duplicate and empty-name messaging in sync with input changes and close the modal on cancel.
Expect the new empty-name validation message in the add-team popup.
…lidation and test fixes
pavanputti
force-pushed
the
fix/create-and-improve-create-new-team
branch
2 times, most recently
from
cbd4b30 to
39d96ba
Compare
pavanputti
force-pushed
the
fix/create-and-improve-create-new-team
branch
from
39d96ba to
46f4b0e
Compare
pavanputti
force-pushed
the
fix/create-and-improve-create-new-team
branch
from
4d54625 to
80bf974
Compare
…dleEditInputChange
pavanputti
force-pushed
the
fix/create-and-improve-create-new-team
branch
from
013bb9d to
455f84c
Compare
|
|
@Anusha-Gali I’ve made the necessary changes. Could you please review when you get a chance? Thanks, |
12 participants
Description
video
Related PRS (if any):
This frontend PR is related to the backend PR 1340
To test this frontend PR, you need to checkout the backend PR 1340.
…
Main changes explained:
Update Create New Team component:
Fixed the bug preventing team creation by correcting the form submission logic and backend API integration.
Implemented UX improvements to match the Profile > Teams > Assign Team > Create New Team workflow, including:
Consistent popup form with team name and optional description fields.
Real-time validation for empty or duplicate team names.
Autocomplete feature showing matching existing teams and an option to create a new team.
Non-existent team creation flow with "Create Team" and "Cancel team creation" options.
Clear success or error messages upon form submission.
…
How to test:
1.Check out the current branch: git checkout fix/create-and-improve-create-new-team
2.Run npm install to install dependencies.
3.Start the app locally with npm start.
4.Clear site data/cache in the browser.
5.Log in as an Admin user or Owner (or a role with team creation permissions).
6.Navigate to Other Links > Team Management > Create New Team and test the following cases:
Screenshots or videos of changes:
Create New Team (Before Fix ):
Create.New.Team.Before.Fix.mov
Create New Team (After Fix ):
Create.New.Team.After.Fix.mov