Skip to content

execution: avoid redundant WithHttpEndpoint when JWT is provided #16032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2025
+5 −1
Merged

execution: avoid redundant WithHttpEndpoint when JWT is provided #16032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9914da8
execution: avoid redundant WithHttpEndpoint when JWT is provided
Forostovec Nov 19, 2025
8531ed6
Create Forostovec_fix-execution-option.md
Forostovec Nov 19, 2025
d722ae6
Merge branch 'develop' into develop
james-prysm Nov 20, 2025
266e50f
Merge branch 'develop' into develop
james-prysm Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/Forostovec_fix-execution-option.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## Changed

- Avoid redundant WithHttpEndpoint when JWT is provided
3 changes: 2 additions & 1 deletion cmd/beacon-chain/execution/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@ func FlagOptions(c *cli.Context) ([]execution.Option, error) {
}
headers := strings.Split(c.String(flags.ExecutionEngineHeaders.Name), ",")
opts := []execution.Option{
execution.WithHttpEndpoint(endpoint),
execution.WithEth1HeaderRequestLimit(c.Uint64(flags.Eth1HeaderReqLimit.Name)),
execution.WithHeaders(headers),
}
if len(jwtSecret) > 0 {
opts = append(opts, execution.WithHttpEndpointAndJWTSecret(endpoint, jwtSecret))
} else {
opts = append(opts, execution.WithHttpEndpoint(endpoint))
}
return opts, nil
}
Expand Down
Loading