execution: avoid redundant WithHttpEndpoint when JWT is provided #16032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
approved these changes
Nov 20, 2025
Contributor
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures FlagOptions in cmd/beacon-chain/execution/options.go appends only one endpoint option depending on whether a JWT secret is present. Previously the code always appended WithHttpEndpoint and then conditionally appended WithHttpEndpointAndJWTSecret which overwrote the first option, adding unnecessary allocations and cognitive overhead. Since WithHttpEndpointAndJWTSecret fully configures the endpoint, including URL and Bearer auth needed by the Engine API, the initial WithHttpEndpoint is redundant when a JWT is supplied. The refactor preserves behavior while simplifying option composition and avoiding redundant state churn.