Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weylus: Add GST plugins to GST_PLUGIN_PATH, weylus: 0.11.4 -> unstable-2022-06-07 #174434

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

zhaofengli
Copy link
Member

@zhaofengli zhaofengli commented May 25, 2022

Description of changes

Redos #145051 after #161052, and bumps to an unstable version for Wayland fixes. Tested working on Sway with an iPad Air on the other end. In xournal++ the Apple Pencil worked correctly with pressure sensitivity.

The Wayland-related fixes are a bit hard to cherry pick as patches, and I'm not sure whether we should bump to unstable or wait for an upstream release before merging. Note that this version is being shipped in upstream's Docker image.

Ref: H-M-H/Weylus#155

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@linsui
Copy link
Contributor

linsui commented May 25, 2022

It runs on xwayland on Gnome. How can I force it using wayland?

@zhaofengli
Copy link
Member Author

It runs on xwayland on Gnome. How can I force it using wayland?

For me the config window also runs in XWayland, but screen capture and event injection work with "Wayland/PipeWire Support" ticked.

@linsui
Copy link
Contributor

linsui commented May 25, 2022

It always works for me with "Wayland/PipeWire Support" ticked. I guess it works different on Gnome and sway...

@zhaofengli zhaofengli marked this pull request as ready for review June 6, 2022 07:26
@fx-chun
Copy link
Member

fx-chun commented Jun 23, 2022

@zhaofengli @legendofmiracles I think we should bump to latest master in this PR; looks like there hasn't been an official release in a while.

@zhaofengli zhaofengli changed the title weylus: Add GST plugins to GST_PLUGIN_PATH, weylus: 0.11.4 -> unstable-2022-05-21 weylus: Add GST plugins to GST_PLUGIN_PATH, weylus: 0.11.4 -> unstable-2022-06-07 Jun 24, 2022
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/542

@SuperSandro2000 SuperSandro2000 merged commit ab18f8f into NixOS:master Jul 5, 2022
@zhaofengli zhaofengli deleted the weylus-sway branch July 6, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants