Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weylus: build from source and fix desktop shortcut #161052

Merged
merged 2 commits into from
Mar 8, 2022
Merged

weylus: build from source and fix desktop shortcut #161052

merged 2 commits into from
Mar 8, 2022

Conversation

linsui
Copy link
Contributor

@linsui linsui commented Feb 20, 2022 •
edited
Loading

Motivation for this change

I'm using weylus. I want to build it from source. The desktop icon is missing. I fix it.

Things done
  1. build weylus from source
  2. fix desktop icon
  3. I thought it works for Mac since it's built from souce. But I don't have a Mac.
  4. I haven't test it with pipewire. @noneucat Could you please help test it?
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@legendofmiracles

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Feb 20, 2022
@ofborg ofborg bot requested a review from legendofmiracles February 20, 2022 12:27
@linsui
Copy link
Contributor Author

linsui commented Mar 1, 2022

@legendofmiracles Ping?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/765

@SuperSandro2000
Copy link
Member

@ofborg eval
@ofborg build weylus

SuperSandro2000
SuperSandro2000 reviewed Mar 7, 2022
View reviewed changes
pkgs/applications/graphics/weylus/default.nix
'';

meta = with lib; {
description = "Use your tablet as graphic tablet/touch screen on your computer";
homepage = "https://github.com/H-M-H/Weylus";
license = with licenses; [ agpl3Only ];
maintainers = with maintainers; [ lom ];
platforms = [ "x86_64-linux" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It currently is not building on darwin because libva -> libdrm -> libpciaccess which does not build on darwin. I don't think we should fix this blind. Not sure if you want to keep it like it is or change something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, libva is only used on linux. H-M-H/Weylus@b47e5f2

@legendofmiracles
Copy link
Contributor

Result of nixpkgs-review pr 161052 run on aarch64-linux 1

1 package built:
  • weylus

@SuperSandro2000
Copy link
Member

Yes, it builds. I don't know if it fully works but at least better than nothing.

@SuperSandro2000 SuperSandro2000 merged commit 73d9e53 into NixOS:master Mar 8, 2022
@linsui linsui deleted the patch-1 branch March 8, 2022 12:57
@linsui
Copy link
Contributor Author

linsui commented Mar 8, 2022

Thanks!

zhaofengli added a commit to zhaofengli/nixpkgs that referenced this pull request May 25, 2022
@zhaofengli @fx-chun
weylus: Add GST plugins to GST_PLUGIN_PATH
94b8710 
Redos NixOS#145051 after NixOS#161052.

Co-authored-by: Andy Chun @noneucat <[email protected]>
@zhaofengli zhaofengli mentioned this pull request May 25, 2022
Merged
13 tasks
zhaofengli
zhaofengli reviewed May 25, 2022
View reviewed changes
pkgs/applications/graphics/weylus/default.nix

postFixup = let
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GST_PLUGIN_PATH is still required (H-M-H/Weylus#155 (comment)). I've opened #174434 to re-add it on Linux.

zhaofengli added a commit to zhaofengli/nixpkgs that referenced this pull request May 30, 2022
@zhaofengli @fx-chun
weylus: Add GST plugins to GST_PLUGIN_PATH
46b8a39 
Redos NixOS#145051 after NixOS#161052.

Co-authored-by: Andy Chun @noneucat <[email protected]>
zhaofengli added a commit to zhaofengli/nixpkgs that referenced this pull request Jun 21, 2022
@zhaofengli @fx-chun
weylus: Add GST plugins to GST_PLUGIN_PATH
feb95e7 
Redos NixOS#145051 after NixOS#161052.

Co-authored-by: Andy Chun @noneucat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaofengli zhaofengli zhaofengli left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@legendofmiracles legendofmiracles Awaiting requested review from legendofmiracles

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@linsui @nixos-discourse @SuperSandro2000 @legendofmiracles @zhaofengli