DynamicTablesPkg/SSDT: Require Package node in hierarchy#74
Open
jeshuasmith wants to merge 1 commit intomasterfrom
Open
DynamicTablesPkg/SSDT: Require Package node in hierarchy#74jeshuasmith wants to merge 1 commit intomasterfrom
jeshuasmith wants to merge 1 commit intomasterfrom
Conversation
jeshuasmith
added
Pending EDK2 Review
The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so update the check to simply require exactly one package node somewhere in the hierarchy. Bug 4429980 Signed-off-by: Jeshua Smith <jeshuas@nvidia.com> Change-Id: Ic5909ca212233153ae444de8ca8e4a4db9772b5a
jeshuasmith
force-pushed
the
Upstream/ProcHierarchyPackageFix
branch
from
c48ed7b to
6666e0a
Compare
jeshuasmith
added
In NVIDIA repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so update the check to simply require exactly one package node somewhere in the hierarchy.