DynamicTablesPkg/SSDT: Remove incorrect root node check#68
Closed
jeshuasmith wants to merge 1 commit intomasterfrom
Closed
DynamicTablesPkg/SSDT: Remove incorrect root node check#68jeshuasmith wants to merge 1 commit intomasterfrom
jeshuasmith wants to merge 1 commit intomasterfrom
Conversation
The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so the check is being removed. Bug 4429980 Signed-off-by: Jeshua Smith <jeshuas@nvidia.com> Change-Id: Ic8279add95ae8dd466b91bf6dcfd3249197ab92e Reviewed-on: https://git-master.nvidia.com/r/c/3rdparty/edk2/+/3047014 Tested-by: Ashish Singhal <ashishsingha@nvidia.com> Reviewed-by: Ashish Singhal <ashishsingha@nvidia.com> Reviewed-by: svcacv <svcacv@nvidia.com> Reviewed-by: svc-mobile-coverity <svc-mobile-coverity@nvidia.com> Reviewed-by: svc-sw-mobile-l4t <svc-sw-mobile-l4t@nvidia.com> GVS: Gerrit_Virtual_Submit <buildbot_gerritrpt@nvidia.com>
jeshuasmith
added
Pending EDK2 Review
jeshuasmith
removed
Pending EDK2 Review
Contributor
Author
|
This PR is replaced by Upstream/ProcHierarchyPackageFix #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was incorrectly assuming that root nodes had to be physical package nodes and vice versa. This is not always true, so the check is being removed.
Signed-off-by: Jeshua Smith jeshuas@nvidia.com
Tested-by: Ashish Singhal ashishsingha@nvidia.com
Reviewed-by: Ashish Singhal ashishsingha@nvidia.com