[features/run] Parse primitive types #2733
+238
−13
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # ============================================================================ # | ||
| # Copyright (c) 2022 - 2025 NVIDIA Corporation & Affiliates. # | ||
| # All rights reserved. # | ||
| # # | ||
| # This source code and the accompanying materials are made available under # | ||
| # the terms of the Apache License 2.0 which accompanies this distribution. # | ||
| # ============================================================================ # | ||
|
|
||
| add_executable(test_record RecordParserTester.cpp) | ||
|
|
||
| if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE) | ||
| target_link_options(test_record PRIVATE -Wl,--no-as-needed) | ||
| endif() | ||
| target_include_directories(test_record PRIVATE ..) | ||
| target_link_libraries(test_record | ||
| PRIVATE | ||
| fmt::fmt-header-only | ||
| cudaq | ||
| fmt::fmt-header-only | ||
| cudaq-common | ||
| gtest_main | ||
| ) | ||
|
|
||
| gtest_discover_tests(test_record) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /******************************************************************************* | ||
| * Copyright (c) 2022 - 2025 NVIDIA Corporation & Affiliates. * | ||
| * All rights reserved. * | ||
| * * | ||
| * This source code and the accompanying materials are made available under * | ||
| * the terms of the Apache License 2.0 which accompanies this distribution. * | ||
| ******************************************************************************/ | ||
|
|
||
| #include "CUDAQTestUtils.h" | ||
| #include "common/RecordLogDecoder.h" | ||
| #include <cudaq.h> | ||
|
|
||
| CUDAQ_TEST(ParserTester, checkSingleBoolean) { | ||
| const std::string log = "OUTPUT\tBOOL\ttrue"; | ||
| cudaq::RecordLogDecoder parser; | ||
| parser.decode(log); | ||
| auto *origBuffer = parser.getBufferPtr(); | ||
| bool value; | ||
| std::memcpy(&value, origBuffer, sizeof(bool)); | ||
| EXPECT_EQ(true, value); | ||
| } | ||
|
|
||
| CUDAQ_TEST(ParserTester, checkIntegers) { | ||
| const std::string log = "OUTPUT\tINT\t0\n" | ||
| "OUTPUT\tINT\t1\n" | ||
| "OUTPUT\tINT\t2\n"; | ||
| cudaq::RecordLogDecoder parser; | ||
| parser.decode(log); | ||
| auto *origBuffer = parser.getBufferPtr(); | ||
| std::size_t bufferSize = parser.getBufferSize(); | ||
| EXPECT_EQ(3, bufferSize / sizeof(int)); | ||
| int *buffer = static_cast<int *>(malloc(bufferSize)); | ||
| std::memcpy(buffer, origBuffer, bufferSize); | ||
| for (int i = 0; i < 3; ++i) | ||
| EXPECT_EQ(i, buffer[i]); | ||
| } | ||
|
|
||
| CUDAQ_TEST(ParserTester, checkDoubles) { | ||
| const std::string log = "START\n" | ||
| "OUTPUT\tDOUBLE\t3.14\n" | ||
| "OUTPUT\tDOUBLE\t2.717\n" | ||
| "END\t0"; | ||
| cudaq::RecordLogDecoder parser; | ||
| parser.decode(log); | ||
| auto *origBuffer = parser.getBufferPtr(); | ||
| std::size_t bufferSize = parser.getBufferSize(); | ||
| EXPECT_EQ(2, bufferSize / sizeof(double)); | ||
| double *buffer = static_cast<double *>(malloc(bufferSize)); | ||
| std::memcpy(buffer, origBuffer, bufferSize); | ||
| EXPECT_EQ(3.14, buffer[0]); | ||
| EXPECT_EQ(2.717, buffer[1]); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: class means these are already private. I prefer private data members and member functions to come last since they are not part of the interface of the class, but implementation details. Putting them up front means the reader has to wade through them to find the interface, which is where one should start reading to figure out what the class is for and does.