[features/run] Parse primitive types #2733
Open
+237
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- primitive types TODO: Handle arrays (vector of results) * Naive way of parsing integer array log Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
…ented for testing only * Addressing PR comment Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
* Updated tests Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
schweitzpgi
reviewed
Mar 14, 2025
Comment on lines
+42
to
+43
| } else if ('f' == label[0]) | ||
| return OutputType::DOUBLE; |
There was a problem hiding this comment.
Suggested change
| } else if ('f' == label[0]) | |
| return OutputType::DOUBLE; | |
| } else if ('f' == label[0]) { | |
| return OutputType::DOUBLE; | |
| } |
nit: balanced braces with if part.
| void addPrimitiveRecord(T value) { | ||
| /// ASKME: Is this efficient? | ||
| std::size_t position = buffer.size(); | ||
| buffer.resize(position + sizeof(T)); |
There was a problem hiding this comment.
For efficiency it might be better to call resize with an overestimate. That way the vector would only be resized every
| /// Simple decoder for translating QIR recorded results to a C++ binary data | ||
| /// structure. | ||
| class RecordLogDecoder { | ||
|
|
||
| private: |
There was a problem hiding this comment.
nit: class means these are already private. I prefer private data members and member functions to come last since they are not part of the interface of the class, but implementation details. Putting them up front means the reader has to wade through them to find the interface, which is where one should start reading to figure out what the class is for and does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not covered: arrays, tuples