Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tutorial: Adapt vqe algorithm #2709

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

marwafar
Copy link
Collaborator

@marwafar marwafar commented Mar 7, 2025

This is a new tutorial that explains how to implement adapt-vqe with UCCSD operator pool in cudaq.

Copy link

copy-pr-bot bot commented Mar 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

marwafar and others added 2 commits March 7, 2025 16:27
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 488a0e3
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 0e96502
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 93d987c

Signed-off-by: marwafar <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Mar 8, 2025

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Mar 8, 2025

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Mar 8, 2025
Copy link

github-actions bot commented Mar 8, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1 similar comment
Copy link

github-actions bot commented Mar 8, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 8, 2025
marwafar added 3 commits March 8, 2025 12:43
Signed-off-by: marwafar <[email protected]>
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 93a7659

Signed-off-by: marwafar <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Mar 8, 2025

@marwafar Please use the following formatting command to fix the failing job in CI

yapf -i <file-path>

Signed-off-by: marwafar <[email protected]>
@marwafar
Copy link
Collaborator Author

marwafar commented Mar 9, 2025

@sacpis Done.

@sacpis
Copy link
Collaborator

sacpis commented Mar 9, 2025

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@sacpis
Copy link
Collaborator

sacpis commented Mar 10, 2025

/ok to test

Command Bot: Processing...

marwafar and others added 4 commits March 12, 2025 12:35
@sacpis
Copy link
Collaborator

sacpis commented Mar 12, 2025

/ok to test

Command Bot: Processing...

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@sacpis
Copy link
Collaborator

sacpis commented Mar 12, 2025

/ok to test

Command Bot: Processing...

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
@sacpis
Copy link
Collaborator

sacpis commented Mar 13, 2025

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Mar 13, 2025

/ok to test

Command Bot: Processing...

@marwafar
Copy link
Collaborator Author

marwafar commented Mar 14, 2025

@sacpis Can I rename the folder adapt_vqe to qchem? I will be adding more chemistry tutorials later and I want to keep one folder for all chemistry codes

@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025

@sacpis Can I rename the folder adapt_vqe to qchem? I will be adding more chemistry tutorials later and I want to keep one folder for all chemistry codes

Sure. For separating chemistry notebooks in one folder, I think we can check with @efratshabtai or @mawolf2023.

@marwafar
Copy link
Collaborator Author

marwafar commented Mar 14, 2025

Not separating notebook, but subroutines. For example, for adapt-vqe notebook, I added a new folder called adapt_vqe where I have a code to generte the operator pool, a code to convert hamiltonian from fermionic to qubits. I need to rename the folder that has these subroutines. Therefore, I do not need to create a folder with subroutine for each new notebook. But rather has one folder with all subroutines related to chemistry

@mawolf2023
Copy link
Contributor

@marwafar @sacpis I have no problem how the folders are named/organized. Going forward my PR for the applications page will just require new applications to add an additional entry to the applications.rst with an appropriate description and tags as well as a preview image.

@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025

Thanks @mawolf2023. @marwafar Cool. Please let me know if you need any help.

Signed-off-by: marwafar <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025

/ok to test

Command Bot: Processing...

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
@sacpis
Copy link
Collaborator

sacpis commented Mar 16, 2025

/ok to test

Command Bot: Processing...

Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants