Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tutorial: Adapt vqe algorithm #2709

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

New tutorial: Adapt vqe algorithm #2709

wants to merge 26 commits into from

Conversation

marwafar
Copy link
Collaborator

@marwafar marwafar commented Mar 7, 2025 •
edited
Loading

This is a new tutorial that explains how to implement adapt-vqe with UCCSD operator pool in cudaq.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

marwafar and others added 2 commits March 7, 2025 16:27
@marwafar
DCO Remediation Commit for marwafar <[email protected]>
974ed79 
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 488a0e3
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 0e96502
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 93d987c

Signed-off-by: marwafar <[email protected]>
@sacpis
Fixing spelling and formatting
e75ab9c 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Mar 8, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Mar 8, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Mar 8, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
40c9010
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 8, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
69c9220
marwafar added 3 commits March 8, 2025 12:43
@marwafar
update comments
df74f69 
Signed-off-by: marwafar <[email protected]>
@marwafar
use double precision
93a7659
@marwafar
DCO Remediation Commit for marwafar <[email protected]>
77980bd 
I, marwafar <[email protected]>, hereby add my Signed-off-by to this commit: 93a7659

Signed-off-by: marwafar <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Mar 8, 2025

@marwafar Please use the following formatting command to fix the failing job in CI

yapf -i <file-path>

@marwafar
yapf
3343dda 
Signed-off-by: marwafar <[email protected]>
@marwafar
Copy link
Collaborator Author

marwafar commented Mar 9, 2025 •
edited
Loading

@sacpis Done.

@sacpis
Copy link
Collaborator

sacpis commented Mar 9, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
8c34ec1
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@sacpis
Copy link
Collaborator

sacpis commented Mar 10, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Mar 12, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 12, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
23c8110
@sacpis
Copy link
Collaborator

sacpis commented Mar 12, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 13, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
7025d47
@sacpis
Copy link
Collaborator

sacpis commented Mar 13, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Mar 13, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@marwafar
Copy link
Collaborator Author

marwafar commented Mar 14, 2025 •
edited
Loading

@sacpis Can I rename the folder adapt_vqe to qchem? I will be adding more chemistry tutorials later and I want to keep one folder for all chemistry codes

@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025

@sacpis Can I rename the folder adapt_vqe to qchem? I will be adding more chemistry tutorials later and I want to keep one folder for all chemistry codes

Sure. For separating chemistry notebooks in one folder, I think we can check with @efratshabtai or @mawolf2023.

@marwafar
Copy link
Collaborator Author

marwafar commented Mar 14, 2025 •
edited
Loading

Not separating notebook, but subroutines. For example, for adapt-vqe notebook, I added a new folder called adapt_vqe where I have a code to generte the operator pool, a code to convert hamiltonian from fermionic to qubits. I need to rename the folder that has these subroutines. Therefore, I do not need to create a folder with subroutine for each new notebook. But rather has one folder with all subroutines related to chemistry

@mawolf2023
Copy link
Contributor

@marwafar @sacpis I have no problem how the folders are named/organized. Going forward my PR for the applications page will just require new applications to add an additional entry to the applications.rst with an appropriate description and tags as well as a preview image.

@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025

Thanks @mawolf2023. @marwafar Cool. Please let me know if you need any help.

@marwafar
renamed folder
770df4c 
Signed-off-by: marwafar <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@sacpis
Copy link
Collaborator

sacpis commented Mar 14, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
54b4624
@sacpis
Copy link
Collaborator

sacpis commented Mar 16, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
0a39be3
@sacpis
Copy link
Collaborator

sacpis commented Mar 17, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
@cuda-quantum-bot
Docs preview for PR #2709.
d3876ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efratshabtai efratshabtai efratshabtai left review comments

@bettinaheim bettinaheim Awaiting requested review from bettinaheim bettinaheim is a code owner

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen 1tnguyen is a code owner

@bmhowe23 bmhowe23 Awaiting requested review from bmhowe23 bmhowe23 is a code owner

@schweitzpgi schweitzpgi Awaiting requested review from schweitzpgi schweitzpgi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marwafar @sacpis @mawolf2023 @efratshabtai